torvalds/linux

View on GitHub
tools/perf/pmu-events/metric.py

Summary

Maintainability
C
1 day
Test Coverage

File metric.py has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
"""Parse or generate representations of perf metrics."""
import ast
import decimal
import json
Severity: Minor
Found in tools/perf/pmu-events/metric.py - About 6 hrs to fix

    Expression has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Expression:
      """Abstract base class of elements in a metric expression."""
    
      def ToPerfJson(self) -> str:
        """Returns a perf json file encoded representation."""
    Severity: Minor
    Found in tools/perf/pmu-events/metric.py - About 2 hrs to fix

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def __init__(self,
      Severity: Minor
      Found in tools/perf/pmu-events/metric.py - About 45 mins to fix

        Function Bracket has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def Bracket(self,
                      other: Expression,
                      other_str: str,
                      rhs: bool = False) -> str:
            """If necessary brackets the given other value.
        Severity: Minor
        Found in tools/perf/pmu-events/metric.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status