torvalds/linux

View on GitHub
tools/perf/scripts/python/event_analyzing_sample.py

Summary

Maintainability
D
2 days
Test Coverage

Function show_pebs_ll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def show_pebs_ll():

        count = con.execute("select count(*) from pebs_ll")
        for t in count:
                print("There is %d records in pebs_ll table" % t[0])
Severity: Minor
Found in tools/perf/scripts/python/event_analyzing_sample.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show_general_events has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def show_general_events():

        # Check the total record number in the table
        count = con.execute("select count(*) from gen_events")
        for t in count:
Severity: Minor
Found in tools/perf/scripts/python/event_analyzing_sample.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

def trace_unhandled(event_name, context, event_fields_dict):
        print (' '.join(['%s=%s'%(k,str(v))for k,v in sorted(event_fields_dict.items())]))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 2 other locations - About 2 hrs to fix
tools/perf/scripts/python/arm-cs-trace-disasm.py on lines 126..127
tools/perf/scripts/python/intel-pt-events.py on lines 109..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in dsoq:
             print("%40s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 137..138
tools/perf/scripts/python/event_analyzing_sample.py on lines 143..144
tools/perf/scripts/python/event_analyzing_sample.py on lines 170..171
tools/perf/scripts/python/event_analyzing_sample.py on lines 176..177
tools/perf/scripts/python/event_analyzing_sample.py on lines 182..183
tools/perf/scripts/python/event_analyzing_sample.py on lines 188..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in latq:
             print("%32s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 137..138
tools/perf/scripts/python/event_analyzing_sample.py on lines 143..144
tools/perf/scripts/python/event_analyzing_sample.py on lines 149..150
tools/perf/scripts/python/event_analyzing_sample.py on lines 170..171
tools/perf/scripts/python/event_analyzing_sample.py on lines 176..177
tools/perf/scripts/python/event_analyzing_sample.py on lines 182..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in symbolq:
             print("%32s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 137..138
tools/perf/scripts/python/event_analyzing_sample.py on lines 149..150
tools/perf/scripts/python/event_analyzing_sample.py on lines 170..171
tools/perf/scripts/python/event_analyzing_sample.py on lines 176..177
tools/perf/scripts/python/event_analyzing_sample.py on lines 182..183
tools/perf/scripts/python/event_analyzing_sample.py on lines 188..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in symbolq:
             print("%32s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 137..138
tools/perf/scripts/python/event_analyzing_sample.py on lines 143..144
tools/perf/scripts/python/event_analyzing_sample.py on lines 149..150
tools/perf/scripts/python/event_analyzing_sample.py on lines 170..171
tools/perf/scripts/python/event_analyzing_sample.py on lines 182..183
tools/perf/scripts/python/event_analyzing_sample.py on lines 188..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in commq:
             print("%16s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 137..138
tools/perf/scripts/python/event_analyzing_sample.py on lines 143..144
tools/perf/scripts/python/event_analyzing_sample.py on lines 149..150
tools/perf/scripts/python/event_analyzing_sample.py on lines 176..177
tools/perf/scripts/python/event_analyzing_sample.py on lines 182..183
tools/perf/scripts/python/event_analyzing_sample.py on lines 188..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in dseq:
             print("%32s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 137..138
tools/perf/scripts/python/event_analyzing_sample.py on lines 143..144
tools/perf/scripts/python/event_analyzing_sample.py on lines 149..150
tools/perf/scripts/python/event_analyzing_sample.py on lines 170..171
tools/perf/scripts/python/event_analyzing_sample.py on lines 176..177
tools/perf/scripts/python/event_analyzing_sample.py on lines 188..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        for row in commq:
             print("%16s %8d     %s" % (row[0], row[1], num2sym(row[1])))
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 6 other locations - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 143..144
tools/perf/scripts/python/event_analyzing_sample.py on lines 149..150
tools/perf/scripts/python/event_analyzing_sample.py on lines 170..171
tools/perf/scripts/python/event_analyzing_sample.py on lines 176..177
tools/perf/scripts/python/event_analyzing_sample.py on lines 182..183
tools/perf/scripts/python/event_analyzing_sample.py on lines 188..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for t in count:
                print("There is %d records in gen_events table" % t[0])
                if t[0] == 0:
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 1 other location - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 160..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for t in count:
                print("There is %d records in pebs_ll table" % t[0])
                if t[0] == 0:
Severity: Major
Found in tools/perf/scripts/python/event_analyzing_sample.py and 1 other location - About 1 hr to fix
tools/perf/scripts/python/event_analyzing_sample.py on lines 127..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status