torvalds/linux

View on GitHub
tools/perf/scripts/python/gecko.py

Summary

Maintainability
B
5 hrs
Test Coverage

File gecko.py has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# gecko.py - Convert perf record output to Firefox's gecko profile format
# SPDX-License-Identifier: GPL-2.0
#
# The script converts perf.data to Gecko Profile Format,
# which can be read by https://profiler.firefox.com/.
Severity: Minor
Found in tools/perf/scripts/python/gecko.py - About 3 hrs to fix

    Function process_event has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def process_event(param_dict: Dict) -> None:
        global start_time
        global tid_to_thread
        time_stamp = (param_dict['sample']['time'] // 1000) / 1000
        pid = param_dict['sample']['pid']
    Severity: Minor
    Found in tools/perf/scripts/python/gecko.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status