Sign upLogin

tpitale/tremolo

View on GitHub
Star
lib/tremolo/noop_tracker.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use yield instead of block.call.
Open

      block.call
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop identifies the use of a &block parameter and block.call where yield would do just as well.

Example:

# bad
def method(&block)
  block.call
end
def another(&func)
  func.call 1, 2, 3
end

# good
def method
  yield
end
def another
  yield 1, 2, 3
end

Use empty lines between method definitions.
Open

    def write_point(series_name, data, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Space missing after semicolon.
Open

    def timing(series_name, value, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

Space missing after semicolon.
Open

    def write_point(series_name, data, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

Put empty method definitions on a single line.
Open

    def initialize(host, port, options={})
    end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Unused method argument - series_name. If it's necessary, use _ or _series_name as an argument name to indicate that it won't be used.
Open

    def time(series_name, tags = {}, &block)
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Use empty lines between method definitions.
Open

    def timing(series_name, value, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Space missing after semicolon.
Open

    def increment(series_name, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

Use empty lines between method definitions.
Open

    def time(series_name, tags = {}, &block)
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Use empty lines between method definitions.
Open

    def write_points(series_name, data, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Space missing after semicolon.
Open

    def decrement(series_name, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

Surrounding space missing in default value assignment.
Open

    def initialize(host, port, options={})
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Use empty lines between method definitions.
Open

    def decrement(series_name, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Space missing after semicolon.
Open

    def write_points(series_name, data, tags = {});end
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

Checks for semicolon (;) not followed by some kind of space.

Example:

# bad
x = 1;y = 2

# good
x = 1; y = 2

Unused method argument - tags. If it's necessary, use _ or _tags as an argument name to indicate that it won't be used.
Open

    def time(series_name, tags = {}, &block)
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Missing top-level class documentation comment.
Open

  class NoopTracker
Severity: Minor
Found in lib/tremolo/noop_tracker.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status