Sign upLogin

trailsjs/smokesignals

View on GitHub
Star

Showing 10 of 10 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ecosys.cloneTrailpacks(repos)
  .then(clones => {
    console.log('clone statuses', clones)
    console.log('>> complete. time elapsed', (new Date() - timer), 'ms')
    console.log('>> 2. installing', repos.length, 'trailpack repositories from npm')
Severity: Major
Found in bin/ci.js and 1 other location - About 2 hrs to fix
bin/ci.js on lines 12..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function checkNodeSecurity has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  checkNodeSecurity (repos) {
    return new Promise((resolve, reject) => {
      const proc = spawn(npm, [ 'install', '-g', 'nsp', '--force' ], {
        stdio: [
          'ignore',
Severity: Minor
Found in lib/ecosystem.js - About 1 hr to fix

    Function npmInstallTrailpacks has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      npmInstallTrailpacks (repos) {
    return Promise.all(repos.map(repo => {
      const wd = path.resolve(process.cwd(), repo.name)
      return new Promise((resolve, reject) => {
        console.log('>> npm install', repo.name)
    Severity: Minor
    Found in lib/ecosystem.js - About 1 hr to fix

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        info () {
    return this.log.apply(this, [ 'info' ].concat(Array.prototype.slice.call(arguments)))
  }
      Severity: Major
      Found in lib/logger.js and 5 other locations - About 45 mins to fix
      lib/logger.js on lines 48..50
      lib/logger.js on lines 51..53
      lib/logger.js on lines 57..59
      lib/logger.js on lines 60..62
      lib/logger.js on lines 63..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        warn () {
    return this.log.apply(this, [ 'warn' ].concat(Array.prototype.slice.call(arguments)))
  }
      Severity: Major
      Found in lib/logger.js and 5 other locations - About 45 mins to fix
      lib/logger.js on lines 48..50
      lib/logger.js on lines 54..56
      lib/logger.js on lines 57..59
      lib/logger.js on lines 60..62
      lib/logger.js on lines 63..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        error () {
    return this.log.apply(this, [ 'error' ].concat(Array.prototype.slice.call(arguments)))
  }
      Severity: Major
      Found in lib/logger.js and 5 other locations - About 45 mins to fix
      lib/logger.js on lines 51..53
      lib/logger.js on lines 54..56
      lib/logger.js on lines 57..59
      lib/logger.js on lines 60..62
      lib/logger.js on lines 63..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        verbose () {
    return this.log.apply(this, [ 'verbose' ].concat(Array.prototype.slice.call(arguments)))
  }
      Severity: Major
      Found in lib/logger.js and 5 other locations - About 45 mins to fix
      lib/logger.js on lines 48..50
      lib/logger.js on lines 51..53
      lib/logger.js on lines 54..56
      lib/logger.js on lines 60..62
      lib/logger.js on lines 63..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        debug () {
    return this.log.apply(this, [ 'debug' ].concat(Array.prototype.slice.call(arguments)))
  }
      Severity: Major
      Found in lib/logger.js and 5 other locations - About 45 mins to fix
      lib/logger.js on lines 48..50
      lib/logger.js on lines 51..53
      lib/logger.js on lines 54..56
      lib/logger.js on lines 57..59
      lib/logger.js on lines 63..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        silly () {
    return this.log.apply(this, [ 'silly' ].concat(Array.prototype.slice.call(arguments)))
  }
      Severity: Major
      Found in lib/logger.js and 5 other locations - About 45 mins to fix
      lib/logger.js on lines 48..50
      lib/logger.js on lines 51..53
      lib/logger.js on lines 54..56
      lib/logger.js on lines 57..59
      lib/logger.js on lines 60..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function log has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        log (level) {
    const args = Array.prototype.slice.call(arguments)
    args.shift()
    const output = [ `smokesignal ${level}:` ].concat(args).map(obj => {
      if (obj instanceof Error) {
      Severity: Minor
      Found in lib/logger.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language