trailsjs/smokesignals

View on GitHub

Showing 3 of 10 total issues

Function checkNodeSecurity has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  checkNodeSecurity (repos) {
    return new Promise((resolve, reject) => {
      const proc = spawn(npm, [ 'install', '-g', 'nsp', '--force' ], {
        stdio: [
          'ignore',
Severity: Minor
Found in lib/ecosystem.js - About 1 hr to fix

    Function npmInstallTrailpacks has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      npmInstallTrailpacks (repos) {
        return Promise.all(repos.map(repo => {
          const wd = path.resolve(process.cwd(), repo.name)
          return new Promise((resolve, reject) => {
            console.log('>> npm install', repo.name)
    Severity: Minor
    Found in lib/ecosystem.js - About 1 hr to fix

      Function log has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        log (level) {
          const args = Array.prototype.slice.call(arguments)
          args.shift()
          const output = [ `smokesignal ${level}:` ].concat(args).map(obj => {
            if (obj instanceof Error) {
      Severity: Minor
      Found in lib/logger.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language