trailsjs/trailpack-waterline

View on GitHub

Showing 15 of 15 total issues

Function find has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  find (modelName, criteria, options) {
    const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
    const modelOptions = _.defaultsDeep({ }, options,
        _.get(this.app.config, 'footprints.models.options'))
    let query
Severity: Minor
Found in api/services/FootprintService.js - About 1 hr to fix

    Function destroyAssociation has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      destroyAssociation (parentModelName, parentId, childAttributeName, criteria, options) {
        const parentModel = this.app.orm[parentModelName] ||
            this.app.packs.waterline.orm.collections[parentModelName]
        const childAttribute = parentModel.attributes[childAttributeName]
        const childModelName = childAttribute.model || childAttribute.collection
    Severity: Minor
    Found in api/services/FootprintService.js - About 1 hr to fix

      Function find has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        find (modelName, criteria, options) {
          const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
          const modelOptions = _.defaultsDeep({ }, options,
              _.get(this.app.config, 'footprints.models.options'))
          let query
      Severity: Minor
      Found in api/services/FootprintService.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const childModel = this.app.orm[childModelName] ||
              this.app.packs.waterline.orm.collections[childModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const parentModel = this.app.orm[parentModelName] ||
              this.app.packs.waterline.orm.collections[parentModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const childModel = this.app.orm[childModelName] ||
              this.app.packs.waterline.orm.collections[childModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const parentModel = this.app.orm[parentModelName] ||
              this.app.packs.waterline.orm.collections[parentModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const parentModel = this.app.orm[parentModelName] ||
              this.app.packs.waterline.orm.collections[parentModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const parentModel = this.app.orm[parentModelName] ||
              this.app.packs.waterline.orm.collections[parentModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const childModel = this.app.orm[childModelName] ||
              this.app.packs.waterline.orm.collections[childModelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 116..116
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
      Severity: Major
      Found in api/services/FootprintService.js and 10 other locations - About 35 mins to fix
      api/services/FootprintService.js on lines 21..21
      api/services/FootprintService.js on lines 35..35
      api/services/FootprintService.js on lines 85..85
      api/services/FootprintService.js on lines 139..140
      api/services/FootprintService.js on lines 159..160
      api/services/FootprintService.js on lines 163..164
      api/services/FootprintService.js on lines 201..202
      api/services/FootprintService.js on lines 205..206
      api/services/FootprintService.js on lines 239..240
      api/services/FootprintService.js on lines 243..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        update (modelName, criteria, values, options) {
          const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
          let query
      
          if (!options) {
      Severity: Minor
      Found in api/services/FootprintService.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language