Sign upLogin

trailsjs/trailpack-waterline

View on GitHub
Star

Showing 4 of 15 total issues

Function find has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  find (modelName, criteria, options) {
    const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
    const modelOptions = _.defaultsDeep({ }, options,
        _.get(this.app.config, 'footprints.models.options'))
    let query
Severity: Minor
Found in api/services/FootprintService.js - About 1 hr to fix

    Function destroyAssociation has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      destroyAssociation (parentModelName, parentId, childAttributeName, criteria, options) {
    const parentModel = this.app.orm[parentModelName] ||
        this.app.packs.waterline.orm.collections[parentModelName]
    const childAttribute = parentModel.attributes[childAttributeName]
    const childModelName = childAttribute.model || childAttribute.collection
    Severity: Minor
    Found in api/services/FootprintService.js - About 1 hr to fix

      Function find has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        find (modelName, criteria, options) {
    const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
    const modelOptions = _.defaultsDeep({ }, options,
        _.get(this.app.config, 'footprints.models.options'))
    let query
      Severity: Minor
      Found in api/services/FootprintService.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        update (modelName, criteria, values, options) {
    const Model = this.app.orm[modelName] || this.app.packs.waterline.orm.collections[modelName]
    let query

    if (!options) {
      Severity: Minor
      Found in api/services/FootprintService.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language