Sign upLogin

trakio/mongo-lock

View on GitHub
Star

Showing 4 of 4 total issues

Method choose_driver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def choose_driver provided_collections
        collections = provided_collections.clone
        collections = collections.values if collections.is_a? Hash

        if collections.is_a? Array
Severity: Minor
Found in lib/mongo-lock/configuration.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method release has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def release options = {}
        options = inherit_options options

        # If the lock has already been released
        if released?
Severity: Minor
Found in lib/mongo-lock/release.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method try_acquire has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def try_acquire options, i, time_spent, &block

        # If timeout has expired
        if options[:timeout_in] && options[:timeout_in] < time_spent
          return raise_or_false options
Severity: Minor
Found in lib/mongo-lock/acquisition.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return true
Severity: Major
Found in lib/mongo-lock/release.rb - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language