Sign upLogin

trampi/repomgmt

View on GitHub
Star

Showing 10 of 10 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

window.Repomgmt.StatisticsRepositories = function(repositoryId) {
    $.get(Routes.statistics_repository_path(repositoryId, {format: "json"}), function(statistics) {

        Morris.Line({
            element: 'repository-statistics-commits-history',
Severity: Major
Found in app/assets/javascripts/statistics_repositories.js and 1 other location - About 7 hrs to fix
app/assets/javascripts/statistics_users.js on lines 1..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 180.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

window.Repomgmt.StatisticsUser = function(userId) {
    $.get(Routes.statistics_user_path(userId, {format: "json"}), function(statistics) {

        Morris.Line({
            element: 'repository-statistics-commits-user-repositories-history',
Severity: Major
Found in app/assets/javascripts/statistics_users.js and 1 other location - About 7 hrs to fix
app/assets/javascripts/statistics_repositories.js on lines 1..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 180.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Class Repository has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Repository < ActiveRecord::Base
  extend MapDaysToCommits
  include MarkForRefreshAuthentication

  default_scope { order(name: :asc) }
Severity: Minor
Found in app/models/repository.rb - About 3 hrs to fix

    Function UserRelations has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    window.Repomgmt.UserRelations = function(userIdsInRepository) {
    // adding users to a project
    $.get(Routes.admin_users_path({format: "json"}), function(allUsers) {
        var usersInRepository = allUsers.filter(function(user) {
            return userIdsInRepository.contains(user.id);
    Severity: Major
    Found in app/assets/javascripts/repositories.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      source: function(query, callback) {
                    var result = filterCollectionForStringAttribute(repositories, "name", query);

                    if(result.length === 0) {
                        result.push({
      Severity: Major
      Found in app/assets/javascripts/search.js and 1 other location - About 2 hrs to fix
      app/assets/javascripts/search.js on lines 70..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      source: function(query, callback) {
                    var result = filterCollectionForStringAttribute(users, "name", query);

                    if(result.length === 0) {
                        result.push({
      Severity: Major
      Found in app/assets/javascripts/search.js and 1 other location - About 2 hrs to fix
      app/assets/javascripts/search.js on lines 30..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function StatisticsSystem has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      window.Repomgmt.StatisticsSystem = function() {
    $.get(Routes.admin_statistics_system_path({format: "json"}), function(statistics) {

        Morris.Line({
            element: 'repository-statistics-commits-history',
      Severity: Minor
      Found in app/assets/javascripts/statistics_system.js - About 1 hr to fix

        Function value has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

                value: function(predicate) {
            if (this == null) {
                throw new TypeError('Array.prototype.find called on null or undefined');
            }
            if (typeof predicate !== 'function') {
        Severity: Minor
        Found in app/assets/javascripts/lib.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                var removeUser = function(userToRemove) {
            usersNotInRepository.push(userToRemove);
            usersInRepository = usersInRepository.filter(function(user) {
                return user != userToRemove;
            });
        Severity: Minor
        Found in app/assets/javascripts/repositories.js and 1 other location - About 50 mins to fix
        app/assets/javascripts/repositories.js on lines 17..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                var addUser = function(userToAdd) {
            usersInRepository.push(userToAdd);
            usersNotInRepository = usersNotInRepository.filter(function(user) {
                return user != userToAdd;
            });
        Severity: Minor
        Found in app/assets/javascripts/repositories.js and 1 other location - About 50 mins to fix
        app/assets/javascripts/repositories.js on lines 24..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language