Sign upLogin

trampi/repomgmt

View on GitHub
Star

Showing 4 of 10 total issues

Class Repository has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Repository < ActiveRecord::Base
  extend MapDaysToCommits
  include MarkForRefreshAuthentication

  default_scope { order(name: :asc) }
Severity: Minor
Found in app/models/repository.rb - About 3 hrs to fix

    Function UserRelations has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    window.Repomgmt.UserRelations = function(userIdsInRepository) {
    // adding users to a project
    $.get(Routes.admin_users_path({format: "json"}), function(allUsers) {
        var usersInRepository = allUsers.filter(function(user) {
            return userIdsInRepository.contains(user.id);
    Severity: Major
    Found in app/assets/javascripts/repositories.js - About 3 hrs to fix

      Function StatisticsSystem has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      window.Repomgmt.StatisticsSystem = function() {
    $.get(Routes.admin_statistics_system_path({format: "json"}), function(statistics) {

        Morris.Line({
            element: 'repository-statistics-commits-history',
      Severity: Minor
      Found in app/assets/javascripts/statistics_system.js - About 1 hr to fix

        Function value has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

                value: function(predicate) {
            if (this == null) {
                throw new TypeError('Array.prototype.find called on null or undefined');
            }
            if (typeof predicate !== 'function') {
        Severity: Minor
        Found in app/assets/javascripts/lib.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language