Sign upLogin

tranlyvu/wiki-link

View on GitHub
Star

Showing 14 of 14 total issues

File wiki_link.py has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

"""Provide Wikilink- Main class of the project"""
Severity: Minor
Found in wikilink/wiki_link.py - About 5 hrs to fix

    Function _single_threaded_scraper has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        def _single_threaded_scraper(self):

        """ Return minimum number of link using single threaded scraper

        Args:
    Severity: Minor
    Found in wikilink/wiki_link.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _worker has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def _worker(self, execution_queue, storage_queue, separation_queue, event):
        
        """ The worker function that pick up url_id from
             execution_queue and scrape
    Severity: Minor
    Found in wikilink/wiki_link.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if db == "postgresql":
            connection = "postgresql+psycopg2://" + name + ":" \
                          + password + "@" + ip + ":" + port
    Severity: Major
    Found in wikilink/db/connection.py and 1 other location - About 1 hr to fix
    wikilink/db/connection.py on lines 27..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            elif db == "mysql":
            connection = "mysql://" + name + ":" + password \
                          + "@" + ip + ":" + port
    Severity: Major
    Found in wikilink/db/connection.py and 1 other location - About 1 hr to fix
    wikilink/db/connection.py on lines 24..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _delegator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _delegator(self, 
                  execution_queue,
                  storage_queue,
                  separation_queue,
                  event,
    Severity: Minor
    Found in wikilink/wiki_link.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if n.to_page_id not in visited_set:

                            visited_set.add(n.to_page_id)
                            queue.appendleft(n.to_page_id)
    Severity: Major
    Found in wikilink/wiki_link.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if n.to_page_id == self.dest_id:
                            return number_of_separation
      Severity: Major
      Found in wikilink/wiki_link.py - About 45 mins to fix

        Function _scraper has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def _scraper(session, url_id):

    """ Scrap urls from given url id and insert into database

    Args:
        Severity: Minor
        Found in wikilink/wiki_link.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setup_db has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def setup_db(self, db, name, password, ip="127.0.0.1", port="3306"):
        Severity: Minor
        Found in wikilink/wiki_link.py - About 35 mins to fix

          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, db, name, password, ip, port):
          Severity: Minor
          Found in wikilink/db/connection.py - About 35 mins to fix

            Function _delegator has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _delegator(self,
            Severity: Minor
            Found in wikilink/wiki_link.py - About 35 mins to fix

              Function _multiprocessing_scraper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _multiprocessing_scraper(self):

        """ Return minimum number of link using single multiprocessing scraper

        Args:
              Severity: Minor
              Found in wikilink/wiki_link.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __init__ has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def __init__(self, db, name, password, ip, port):
        
        if db == "postgresql":
            connection = "postgresql+psycopg2://" + name + ":" \
                          + password + "@" + ip + ":" + port
              Severity: Minor
              Found in wikilink/db/connection.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language