Sign upLogin

translation/laravel

View on GitHub
Star

Showing 22 of 22 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    private function makeRequest($client, $body, $command)
    {
        try {
            $response = $client->request(
                'POST', '', [
Severity: Major
Found in src/Service/Sync.php and 2 other locations - About 3 hrs to fix
src/Service/Init.php on lines 91..113
src/Service/SourceEditSync.php on lines 76..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    private function makeRequest($client, $body, $command)
    {
        try {
            $response = $client->request(
                'POST', '', [
Severity: Major
Found in src/Service/SourceEditSync.php and 2 other locations - About 3 hrs to fix
src/Service/Init.php on lines 91..113
src/Service/Sync.php on lines 119..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    private function makeRequest($client, $body, $command)
    {
        try {
            $response = $client->request(
                'POST', '', [
Severity: Major
Found in src/Service/Init.php and 2 other locations - About 3 hrs to fix
src/Service/SourceEditSync.php on lines 76..98
src/Service/Sync.php on lines 119..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function displayUnusedSegments has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    private function displayUnusedSegments($responseData, $command, $showPurgeable, $purge)
    {
        $unusedSegments = collect($responseData['unused_segments']);

        $yamlUnusedSegments = $unusedSegments->filter(
Severity: Minor
Found in src/Service/Sync.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method displayUnusedSegments has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function displayUnusedSegments($responseData, $command, $showPurgeable, $purge)
    {
        $unusedSegments = collect($responseData['unused_segments']);

        $yamlUnusedSegments = $unusedSegments->filter(
Severity: Major
Found in src/Service/Sync.php - About 2 hrs to fix

    File GettextPOGenerator.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Tio\Laravel;

use Illuminate\Contracts\Foundation\Application;
    Severity: Minor
    Found in src/GettextPOGenerator.php - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace Tio\Laravel\Console\Commands;

use Illuminate\Console\Command;
      Severity: Major
      Found in src/Console/Commands/SyncAndShowPurgeable.php and 2 other locations - About 2 hrs to fix
      src/Console/Commands/Sync.php on lines 1..44
      src/Console/Commands/SyncAndPurge.php on lines 1..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace Tio\Laravel\Console\Commands;

use Illuminate\Console\Command;
      Severity: Major
      Found in src/Console/Commands/Sync.php and 2 other locations - About 2 hrs to fix
      src/Console/Commands/SyncAndPurge.php on lines 1..44
      src/Console/Commands/SyncAndShowPurgeable.php on lines 1..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace Tio\Laravel\Console\Commands;

use Illuminate\Console\Command;
      Severity: Major
      Found in src/Console/Commands/SyncAndPurge.php and 2 other locations - About 2 hrs to fix
      src/Console/Commands/Sync.php on lines 1..44
      src/Console/Commands/SyncAndShowPurgeable.php on lines 1..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function validJsonFile has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function validJsonFile($fileName)
    {
        $result = json_decode(file_get_contents($fileName), true);

        switch (json_last_error()) {
      Severity: Minor
      Found in src/GettextPOGenerator.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function call has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function call($locale, $poContent)
    {
        $localeDir = $this->localePath($locale);
        $lcMessagesDir = $localeDir . DIRECTORY_SEPARATOR . 'LC_MESSAGES';
        $poFile = $localeDir . DIRECTORY_SEPARATOR . 'app.po';
      Severity: Minor
      Found in src/GettextTranslationSaver.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validJsonFile has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function validJsonFile($fileName)
    {
        $result = json_decode(file_get_contents($fileName), true);

        switch (json_last_error()) {
      Severity: Minor
      Found in src/GettextPOGenerator.php - About 1 hr to fix

        Method scan has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function scan($targets)
    {
        $this->gettextFunctionsToExtract();

        $translations = new Translations();
        Severity: Minor
        Found in src/GettextPOGenerator.php - About 1 hr to fix

          Method call has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function call($locale, $poContent)
    {
        $localeDir = $this->localePath($locale);
        $lcMessagesDir = $localeDir . DIRECTORY_SEPARATOR . 'LC_MESSAGES';
        $poFile = $localeDir . DIRECTORY_SEPARATOR . 'app.po';
          Severity: Minor
          Found in src/GettextTranslationSaver.php - About 1 hr to fix

            Function scan has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function scan($targets)
    {
        $this->gettextFunctionsToExtract();

        $translations = new Translations();
            Severity: Minor
            Found in src/GettextPOGenerator.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method call has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function call($source, $targets)
    {
        $this->sourceEntries = collect($this->extractor->call($source));
        $this->sourceEntryKeys = $this->sourceEntries->keys();
            Severity: Minor
            Found in src/TargetPOGenerator.php - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                          if ($this->filesystem->exists($targetJsonFile) && $this->validJsonFile($targetJsonFile)) {
                $targetJsonTranslations = json_decode(file_get_contents($targetJsonFile), true);

                foreach ($targetJsonTranslations as $key => $value) {
                    $jsonPath = dirname($targetJsonFile);
              Severity: Major
              Found in src/GettextPOGenerator.php - About 1 hr to fix

                Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        Application $application,
        SourcePOGenerator $poGenerator,
        GettextPOGenerator $gettextPoGenerator,
        POExtractor $poExtractor,
        TranslationSaver $translationSaver,
                Severity: Minor
                Found in src/Service/Sync.php - About 45 mins to fix

                  Consider simplifying this complex logical expression.
                  Open

                          if ($this->filesystem->exists($poPath)) {
            $existingTargetTranslations = Translations::fromPoFile($poPath);

            $translations->mergeWith(
                $existingTargetTranslations,
                  Severity: Major
                  Found in src/GettextPOGenerator.php - About 40 mins to fix

                    Function addStringsFromJsonFiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function addStringsFromJsonFiles($translations)
    {
        $sourceStrings = [];

        // Load each JSON file to get source strings
                    Severity: Minor
                    Found in src/GettextPOGenerator.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language