Sign upLogin

travi/php-framework

View on GitHub
Star

Showing 176 of 176 total issues

Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($options = array())
    {
        if (isset($options['legend'])) {
            $this->legend = $options['legend'];
        }
Severity: Minor
Found in php/framework/src/travi/framework/components/Forms/FieldSet.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                    if ( strstr( $pv_browser_string, 'os x' ) )
                    {
                        // if it doesn't have a version number, it is os x;
                        if ( strstr( $pv_browser_string, 'os x ' ) )
                        {
Severity: Major
Found in php/thirdparty/browser_detection.php - About 40 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if(!window.opera) addLining(context,border,border,canvas.width-(border*2),canvas.height-(border*4),opacity,inset,true);
    Severity: Minor
    Found in client/thirdparty/instant/instant.js and 1 other location - About 40 mins to fix
    client/thirdparty/instant/instant.js on lines 407..407

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if(!window.opera) addLining(context,border,border,canvas.width-(border*2),canvas.height-(border*2),opacity,inset,true);
    Severity: Minor
    Found in client/thirdparty/instant/instant.js and 1 other location - About 40 mins to fix
    client/thirdparty/instant/instant.js on lines 401..401

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function wavedPath has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function wavedPath(x,y,w,h,r){
    Severity: Minor
    Found in client/thirdparty/instant/instant.js - About 35 mins to fix

      Method _httpsrequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function _httpsrequest($url,$URI,$http_method,$content_type="",$body="")
      Severity: Minor
      Found in php/thirdparty/Snoopy/Snoopy.class.php - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!is_dir($this->directoryToPutFile.$this->thumbDirectory)) {
            //use the recursive attribute when php version has been upgraded to 5.0.0 or higher
            mkdir($this->directoryToPutFile.$this->thumbDirectory, 0755, true);

            //needed before php version 5.0.0
        Severity: Minor
        Found in php/framework/objects/utility/upload.class.php and 1 other location - About 35 mins to fix
        php/framework/objects/utility/upload.class.php on lines 331..343

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!is_dir($this->directoryToPutFile.$this->previewDirectory)) {
            //use the recursive attribute when php version has been upgraded to 5.0.0 or higher
            mkdir($this->directoryToPutFile.$this->previewDirectory, 0755, true);

            //needed before php version 5.0.0
        Severity: Minor
        Found in php/framework/objects/utility/upload.class.php and 1 other location - About 35 mins to fix
        php/framework/objects/utility/upload.class.php on lines 345..357

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function init has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function init($config)
    {
        $this->config = $config;

        if (isset($config['siteName'])) {
        Severity: Minor
        Found in php/framework/src/travi/framework/http/Response.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addReflections has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function addReflections() {
    var rimages = document.myGetElementsByClassName('reflect');
    for (i=0;i<rimages.length;i++) {
        var rheight = null;
        var ropacity = null;
        Severity: Minor
        Found in client/thirdparty/reflection/reflection.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute ()
    {
        $ch = curl_init();
        $this->setAuth($ch);
        Severity: Minor
        Found in php/framework/src/travi/framework/http/RestClient.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function containsFormElementType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function containsFormElementType($type)
    {
        foreach ($this->formElements as $formElement) {
            if (is_a($formElement, $type)) {
                return true;
        Severity: Minor
        Found in php/framework/src/travi/framework/components/Forms/FormElementGroup.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function constructObject has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function constructObject() {

        $this->loadMap();

        if ($this->_map->has('constructor')) {
        Severity: Minor
        Found in php/thirdparty/PHP-Dependency/library/Pd/Make/Constructor.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getValidations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getValidations()
    {
        $validations = array();

        foreach ($this->formElements as $formElement) {
        Severity: Minor
        Found in php/framework/src/travi/framework/components/Forms/FormElementGroup.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getErrors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getErrors()
    {
        $errors = array();

        foreach ($this->getFormElements() as $element) {
        Severity: Minor
        Found in php/framework/src/travi/framework/components/Forms/FormElementGroup.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildMethods has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function buildMethods() {

        $methods = $this->_reflect->getMethods();

        foreach($methods as $method) {
        Severity: Minor
        Found in php/thirdparty/PHP-Dependency/library/Pd/Map/Builder/Class.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function optionAdder has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function optionAdder($options=array())
    {
        if (isset($this->settings['optGroups'])) {
            foreach ($options as $optGroup => $values) {
                $this->optGroups[$optGroup] = array();
        Severity: Minor
        Found in php/framework/src/travi/framework/components/Forms/choices/SelectionBox.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in php/thirdparty/Snoopy/Snoopy.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return ("You must select a file for upload");
          Severity: Major
          Found in php/framework/objects/utility/upload.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return ("There was an unknown problem with your upload");
            Severity: Major
            Found in php/framework/objects/utility/upload.class.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language