Sign upLogin

travi/php-framework

View on GitHub
Star
php/framework/objects/utility/upload.class.php

Summary

Maintainability
D
2 days
Test Coverage

Function upload has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    function upload($isImage=false)
    {
        if ($this->acceptedMimetype($this->mimetype)) {
            $this->checkDirectory();
Severity: Minor
Found in php/framework/objects/utility/upload.class.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File upload.class.php has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class Uploader
{
    var $file_ref;
Severity: Minor
Found in php/framework/objects/utility/upload.class.php - About 5 hrs to fix

    Method upload has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function upload($isImage=false)
    {
        if ($this->acceptedMimetype($this->mimetype)) {
            $this->checkDirectory();
    Severity: Major
    Found in php/framework/objects/utility/upload.class.php - About 2 hrs to fix

      Method createPreview has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function createPreview($newHeight,$newWidth)
    {
        if (empty($newHeight) && empty($newWidth)) {
            $newHeight = 275;
            $newWidth = 250;
      Severity: Minor
      Found in php/framework/objects/utility/upload.class.php - About 2 hrs to fix

        Function checkAdditionalRequirements has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            function checkAdditionalRequirements()
    {
        $status = "good";
        $msg = "Image passed image specific requirements";
        Severity: Minor
        Found in php/framework/objects/utility/upload.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createPreview has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            function createPreview($newHeight,$newWidth)
    {
        if (empty($newHeight) && empty($newWidth)) {
            $newHeight = 275;
            $newWidth = 250;
        Severity: Minor
        Found in php/framework/objects/utility/upload.class.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createSquareThumb has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function createSquareThumb($thumb_size = "")
    {
        if (empty($thumb_size)) {
            $thumb_size = 75;
        }
        Severity: Minor
        Found in php/framework/objects/utility/upload.class.php - About 1 hr to fix

          Method checkAdditionalRequirements has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function checkAdditionalRequirements()
    {
        $status = "good";
        $msg = "Image passed image specific requirements";
          Severity: Minor
          Found in php/framework/objects/utility/upload.class.php - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return ("You must select a file for upload");
            Severity: Major
            Found in php/framework/objects/utility/upload.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return ("There was an unknown problem with your upload");
              Severity: Major
              Found in php/framework/objects/utility/upload.class.php - About 30 mins to fix

                Function buildQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    function buildQuery()
    {
        $thisFileId = "";
        if (isset($this->dbConnection) && isset($this->insertIdQuery)) {
            $thisFileId = $this->getInsertId();
                Severity: Minor
                Found in php/framework/objects/utility/upload.class.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (!is_dir($this->directoryToPutFile.$this->thumbDirectory)) {
            //use the recursive attribute when php version has been upgraded to 5.0.0 or higher
            mkdir($this->directoryToPutFile.$this->thumbDirectory, 0755, true);

            //needed before php version 5.0.0
                Severity: Minor
                Found in php/framework/objects/utility/upload.class.php and 1 other location - About 35 mins to fix
                php/framework/objects/utility/upload.class.php on lines 331..343

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (!is_dir($this->directoryToPutFile.$this->previewDirectory)) {
            //use the recursive attribute when php version has been upgraded to 5.0.0 or higher
            mkdir($this->directoryToPutFile.$this->previewDirectory, 0755, true);

            //needed before php version 5.0.0
                Severity: Minor
                Found in php/framework/objects/utility/upload.class.php and 1 other location - About 35 mins to fix
                php/framework/objects/utility/upload.class.php on lines 345..357

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status