Sign upLogin

treasure-data/embulk-input-jira

View on GitHub
Star
src/main/java/org/embulk/input/jira/util/JiraUtil.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method addRecord has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void addRecord(final Issue issue, final Schema schema, final PluginTask task, final PageBuilder pageBuilder)
    {
        schema.visitColumns(new ColumnVisitor() {
            @Override
            public void jsonColumn(final Column column)
Severity: Major
Found in src/main/java/org/embulk/input/jira/util/JiraUtil.java - About 3 hrs to fix

    Method validateTaskConfig has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static void validateTaskConfig(final PluginTask task)
    {
        final String username = task.getUsername();
        if (isNullOrEmpty(username)) {
            throw new ConfigException("Username or email could not be empty");
    Severity: Minor
    Found in src/main/java/org/embulk/input/jira/util/JiraUtil.java - About 1 hr to fix

      Method validateTaskConfig has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static void validateTaskConfig(final PluginTask task)
    {
        final String username = task.getUsername();
        if (isNullOrEmpty(username)) {
            throw new ConfigException("Username or email could not be empty");
      Severity: Minor
      Found in src/main/java/org/embulk/input/jira/util/JiraUtil.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  @Override
            public void booleanColumn(final Column column)
            {
                final Boolean value = getBooleanValue(issue.getValue(column.getName()));
                if (value == null) {
      Severity: Major
      Found in src/main/java/org/embulk/input/jira/util/JiraUtil.java and 2 other locations - About 40 mins to fix
      src/main/java/org/embulk/input/jira/util/JiraUtil.java on lines 239..249
      src/main/java/org/embulk/input/jira/util/JiraUtil.java on lines 251..261

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  @Override
            public void doubleColumn(final Column column)
            {
                final Double value = getDoubleValue(issue.getValue(column.getName()));
                if (value == null) {
      Severity: Major
      Found in src/main/java/org/embulk/input/jira/util/JiraUtil.java and 2 other locations - About 40 mins to fix
      src/main/java/org/embulk/input/jira/util/JiraUtil.java on lines 227..237
      src/main/java/org/embulk/input/jira/util/JiraUtil.java on lines 239..249

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  @Override
            public void longColumn(final Column column)
            {
                final Long value = getLongValue(issue.getValue(column.getName()));
                if (value == null) {
      Severity: Major
      Found in src/main/java/org/embulk/input/jira/util/JiraUtil.java and 2 other locations - About 40 mins to fix
      src/main/java/org/embulk/input/jira/util/JiraUtil.java on lines 227..237
      src/main/java/org/embulk/input/jira/util/JiraUtil.java on lines 251..261

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status