Sign upLogin

treasure-data/embulk-input-marketo

View on GitHub
Star
src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java

Summary

Maintainability
B
6 hrs
Test Coverage

MarketoServiceImpl has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

public class MarketoServiceImpl implements MarketoService
{
    private final Logger logger = LoggerFactory.getLogger(getClass());

    private static final String DEFAULT_FILE_FORMAT = "csv";
Severity: Minor
Found in src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java - About 2 hrs to fix

    Method extractLead has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public File extractLead(final Date startTime, Date endTime, List<String> extractedFields, String filterField, int pollingTimeIntervalSecond, final int bulkJobTimeoutSecond)
    Severity: Minor
    Found in src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java - About 45 mins to fix

      Method extractAllActivity has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public File extractAllActivity(List<Integer> activityTypeIds, Date startTime, Date endTime, int pollingTimeIntervalSecond, int bulkJobTimeoutSecond)
      Severity: Minor
      Found in src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java - About 35 mins to fix

        Method getCustomObject has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public Iterable<ObjectNode> getCustomObject(String customObjectAPIName, String customObjectFilterType, String customObjectFields, Integer fromValue, Integer toValue)
        Severity: Minor
        Found in src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    public Iterable<ObjectNode> getAllListLead(List<String> fieldNames, Iterable<ObjectNode> inputListIds)
    {
        final String fieldNameString = StringUtils.join(fieldNames, ",");
        return MarketoUtils.flatMap(inputListIds, input -> {
          Severity: Major
          Found in src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java and 1 other location - About 1 hr to fix
          src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java on lines 145..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    public Iterable<ObjectNode> getAllProgramLead(List<String> fieldNames, Iterable<ObjectNode> requestProgs)
    {
        final String fieldNameString = StringUtils.join(fieldNames, ",");
        return MarketoUtils.flatMap(requestProgs, input -> {
          Severity: Major
          Found in src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java and 1 other location - About 1 hr to fix
          src/main/java/org/embulk/input/marketo/MarketoServiceImpl.java on lines 135..143

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status