Sign upLogin

treasure-data/embulk-input-mixpanel

View on GitHub
Star

Showing 12 of 12 total issues

Method ingest has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

        def ingest(task, page_builder)
          giveup_when_mixpanel_is_down

          @schema = task[:schema]
          @timezone = task[:timezone]
Severity: Minor
Found in lib/embulk/input/service/export_service.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ingest has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

        def ingest(task, page_builder)
          @dates = task[:dates]
          @schema = task[:schema]
          @timezone = task[:timezone]
          @incremental_column = task[:incremental_column]
Severity: Minor
Found in lib/embulk/input/service/jql_service.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ingest has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def ingest(task, page_builder)
          giveup_when_mixpanel_is_down

          @schema = task[:schema]
          @timezone = task[:timezone]
Severity: Major
Found in lib/embulk/input/service/export_service.rb - About 2 hrs to fix

    Method extract_value has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            def extract_value(record, name)
          case name
          when NOT_PROPERTY_COLUMN
            record[NOT_PROPERTY_COLUMN]
          when "time"
    Severity: Minor
    Found in lib/embulk/input/service/jql_service.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ingest has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def ingest(task, page_builder)
          @dates = task[:dates]
          @schema = task[:schema]
          @timezone = task[:timezone]
          @incremental_column = task[:incremental_column]
    Severity: Minor
    Found in lib/embulk/input/service/jql_service.rb - About 1 hr to fix

      Method extract_value has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def extract_value(record, name)
          case name
          when NOT_PROPERTY_COLUMN
            record[NOT_PROPERTY_COLUMN]
          when "time"
      Severity: Minor
      Found in lib/embulk/input/service/jql_service.rb - About 1 hr to fix

        Method request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def request(params, &block)
          # https://mixpanel.com/docs/api-documentation/exporting-raw-data-you-inserted-into-mixpanel
          Embulk.logger.debug "Export param: #{params.to_s}"

          buf = ""
        Severity: Minor
        Found in lib/embulk/input/mixpanel_api/client.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method guess_from_records has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def guess_from_records(sample_props)
          validate_result(sample_props)

          begin
            schema = Guess::SchemaGuess.from_hash_records(sample_props)
        Severity: Minor
        Found in lib/embulk/input/service/jql_service.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method fetch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def fetch(dates, last_fetch_time, task, &block)
          from_date = dates.first
          to_date = dates.last
          params = task[:params].merge(
            "from_date"=>from_date,
        Severity: Minor
        Found in lib/embulk/input/service/export_service.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method export_for_small_dataset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def export_for_small_dataset(params = {})
          yesterday = Date.today - 1
          latest_tried_to_date = nil
          try_to_dates(params["from_date"]).each do |to_date|
            next if yesterday < to_date
        Severity: Minor
        Found in lib/embulk/input/mixpanel_api/client.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  when "time"
            if record["time"].present?
              value = record["time"]
              if value > 0
                time = record["time"] / 1000
        Severity: Minor
        Found in lib/embulk/input/service/jql_service.rb and 1 other location - About 20 mins to fix
        lib/embulk/input/service/jql_service.rb on lines 213..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  when "last_seen"
            if record["last_seen"].present?
              value = record["last_seen"]
              if value > 0
                # last_seen format in ms
        Severity: Minor
        Found in lib/embulk/input/service/jql_service.rb and 1 other location - About 20 mins to fix
        lib/embulk/input/service/jql_service.rb on lines 203..210

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language