trestrantham/walkman

View on GitHub

Showing 3 of 3 total issues

Method startup has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def startup
      services.each do |key, service|
        service.startup
      end

Severity: Minor
Found in lib/walkman/player.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method startup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def startup
      services.each do |key, service|
        service.startup
      end

Severity: Minor
Found in lib/walkman/player.rb - About 1 hr to fix

    Method next has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def next(count = 1)
          # if the playlist is not empty, we can get one or more
          # songs back so we need to make sure we get the last one
          songs = @queue.shift(count)
          songs = [songs].flatten
    Severity: Minor
    Found in lib/walkman/playlist.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language