Sign upLogin

trotzig/diffux

View on GitHub
Star

Showing 579 of 579 total issues

Function remove has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    remove: function( elem, types, handler, selector, mappedTypes ) {
Severity: Minor
Found in bower_components/jquery/src/event.js - About 35 mins to fix

    Method compare? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def compare?
    return false unless image_file_name
    return false if accepted?
    compare_with = compared_with || url.baseline(viewport)
    return false unless compare_with
    Severity: Minor
    Found in app/models/snapshot.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def perform(snapshot_id)
    return unless set_snapshot(snapshot_id)
    return unless @snapshot.compare?

    url          = @snapshot.url
    Severity: Minor
    Found in app/workers/snapshot_comparer_worker.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    function completed() {
    document.removeEventListener( "DOMContentLoaded", completed, false );
    window.removeEventListener( "load", completed, false );
    jQuery.ready();
}
    Severity: Minor
    Found in bower_components/jquery/dist/jquery.js and 1 other location - About 35 mins to fix
    bower_components/jquery/src/core/ready.js on lines 64..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    function completed() {
    document.removeEventListener( "DOMContentLoaded", completed, false );
    window.removeEventListener( "load", completed, false );
    jQuery.ready();
}
    Severity: Minor
    Found in bower_components/jquery/src/core/ready.js and 1 other location - About 35 mins to fix
    bower_components/jquery/dist/jquery.js on lines 3430..3434

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    jQuery.expr.filters.visible = function( elem ) {
    return !jQuery.expr.filters.hidden( elem );
};
    Severity: Minor
    Found in bower_components/jquery/dist/jquery.js and 1 other location - About 35 mins to fix
    bower_components/jquery/src/css/hiddenVisibleSelectors.js on lines 11..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    jQuery.expr.filters.visible = function( elem ) {
    return !jQuery.expr.filters.hidden( elem );
};
    Severity: Minor
    Found in bower_components/jquery/src/css/hiddenVisibleSelectors.js and 1 other location - About 35 mins to fix
    bower_components/jquery/dist/jquery.js on lines 8410..8412

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                return this;
    Severity: Major
    Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return results;
      Severity: Major
      Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return sortInput ?
                ( indexOf( sortInput, a ) - indexOf( sortInput, b ) ) :
                0;
        Severity: Major
        Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return ret;
          Severity: Major
          Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return results;
            Severity: Major
            Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return ret == null ?
                undefined :
                ret;
              Severity: Major
              Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return ret == null ?
                undefined :
                ret;
                Severity: Major
                Found in bower_components/jquery/src/attributes/attr.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return ret;
                  Severity: Major
                  Found in bower_components/jquery/src/attributes/attr.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return this.constructor( context ).find( selector );
                    Severity: Major
                    Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return typeof rootjQuery.ready !== "undefined" ?
                rootjQuery.ready( selector ) :
                // Execute immediately if ready is not present
                selector( jQuery );
                      Severity: Major
                      Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return select( selector.replace( rtrim, "$1" ), context, results, seed );
                        Severity: Major
                        Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return results;
                          Severity: Major
                          Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return compare & 4 ? -1 : 1;
                            Severity: Major
                            Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language