Sign upLogin

trufflesuite/truffle

View on GitHub
Star

Showing 1,401 of 1,401 total issues

Function breakpoints has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function breakpoints(state = [], action) {
  switch (action.type) {
    case actions.ADD_BREAKPOINT:
      //check for any existing identical breakpoints to avoid redundancy
      if (
Severity: Minor
Found in packages/debugger/lib/controller/reducers.js - About 1 hr to fix

    Function literalAssignments has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function literalAssignments(
  compilationId,
  internalFor,
  node,
  stack,
    Severity: Minor
    Found in packages/debugger/lib/data/sagas/index.js - About 1 hr to fix

      Function debuggerContextToDecoderContext has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function debuggerContextToDecoderContext(context) {
  let {
    context: contextHash,
    contractName,
    binary,
      Severity: Minor
      Found in packages/debugger/lib/data/selectors/index.js - About 1 hr to fix

        Function stepOver has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function* stepOver() {
  const startingDepth = yield select(controller.current.functionDepth);
  const startingLocation = yield select(controller.current.location);
  const startingNode = yield select(controller.current.location.node);
  let currentDepth;
        Severity: Minor
        Found in packages/debugger/lib/controller/sagas/index.js - About 1 hr to fix

          Function sources has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async sources({ options }) {
    options = Config.default().merge(options);
    if (options.logger == null) {
      options.logger = console;
    }
          Severity: Minor
          Found in packages/external-compile/index.js - About 1 hr to fix

            Function numbers has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const numbers = function(result, abiSegment) {
  const format = this.numberFormat;

  abiSegment.forEach((output, i) => {
    // output is a number type (uint || int);
            Severity: Minor
            Found in packages/contract/lib/reformat.js - About 1 hr to fix

              Function forAddress has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public async forAddress(
    address: string,
    block: BlockSpecifier = "latest"
  ): Promise<ContractInstanceDecoder> {
    if (!Web3Utils.isAddress(address)) {
              Severity: Minor
              Found in packages/decoder/lib/decoders.ts - About 1 hr to fix

                Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  constructor(contractDecoder: ContractDecoder, address?: string) {
    this.contractDecoder = contractDecoder;
    this.projectDecoder = this.contractDecoder.getProjectDecoder();
    this.providerAdapter = this.projectDecoder.getProviderAdapter();
    if (address !== undefined) {
                Severity: Minor
                Found in packages/decoder/lib/decoders.ts - About 1 hr to fix

                  Function saveAll has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    async saveAll(artifactObjects: any | Array<object>) {
    let newArtifactObjects: any = {};

    if (Array.isArray(artifactObjects)) {
      const tmpArtifactArray = artifactObjects;
                  Severity: Minor
                  Found in packages/artifactor/index.ts - About 1 hr to fix

                    Function makeSolidityDeployedAddressesLibrary has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      static makeSolidityDeployedAddressesLibrary(
    mapping: { [key: string]: string | false },
    { solc: { version } }: solcOptionsArg
  ): string {
    let source = "";
                    Severity: Minor
                    Found in packages/resolver/lib/sources/truffle/Deployed.ts - About 1 hr to fix

                      Function exec has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export function exec(options: ExecOptions, done: (...args: any[]) => void) {
  expectOptions(options, [
    "contracts_build_directory",
    "file",
    "resolver",
                      Severity: Minor
                      Found in packages/require/lib/index.ts - About 1 hr to fix

                        Function get has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            *get<N extends CollectionName<C>>(
      collectionName: N,
      id: string,
      document: graphql.DocumentNode
    ): Process<C, Resource<C, N>> {
                        Severity: Minor
                        Found in packages/db/src/meta/process/resources.ts - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            contractName: {
    get: function () {
      return this._json.contractName || "Contract";
    },
    set: function (val) {
                          Severity: Major
                          Found in packages/contract/lib/contract/properties.js and 1 other location - About 1 hr to fix
                          packages/contract/lib/contract/properties.js on lines 372..379

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            networkType: {
    get: function () {
      return this._json.networkType || "ethereum";
    },
    set: function (_networkType) {
                          Severity: Major
                          Found in packages/contract/lib/contract/properties.js and 1 other location - About 1 hr to fix
                          packages/contract/lib/contract/properties.js on lines 13..20

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                  {
          name: "a",
          type: "tuple",
          internalType: "struct Contract.Struct1",
          components: [
                          Severity: Major
                          Found in packages/abi-utils/lib/signature.test.ts and 3 other locations - About 1 hr to fix
                          packages/abi-utils/lib/signature.test.ts on lines 112..128
                          packages/abi-utils/lib/signature.test.ts on lines 146..162
                          packages/abi-utils/lib/signature.test.ts on lines 163..179

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                      {
              name: "ab",
              type: "tuple",
              internalType: "struct Contract.Struct3",
              components: [
                          Severity: Major
                          Found in packages/abi-utils/lib/signature.test.ts and 3 other locations - About 1 hr to fix
                          packages/abi-utils/lib/signature.test.ts on lines 84..100
                          packages/abi-utils/lib/signature.test.ts on lines 146..162
                          packages/abi-utils/lib/signature.test.ts on lines 163..179

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                  {
          name: "a",
          type: "tuple[2][][2]",
          internalType: "struct Contract.Struct1",
          components: [
                          Severity: Major
                          Found in packages/abi-utils/lib/signature.test.ts and 3 other locations - About 1 hr to fix
                          packages/abi-utils/lib/signature.test.ts on lines 84..100
                          packages/abi-utils/lib/signature.test.ts on lines 112..128
                          packages/abi-utils/lib/signature.test.ts on lines 163..179

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                  {
          name: "b",
          type: "tuple[][2][]",
          internalType: "struct Contract.Struct1",
          components: [
                          Severity: Major
                          Found in packages/abi-utils/lib/signature.test.ts and 3 other locations - About 1 hr to fix
                          packages/abi-utils/lib/signature.test.ts on lines 84..100
                          packages/abi-utils/lib/signature.test.ts on lines 112..128
                          packages/abi-utils/lib/signature.test.ts on lines 146..162

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function createMultistepSelectors has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function createMultistepSelectors(stepSelector) {
  return {
    /**
     * .instruction
     */
                          Severity: Minor
                          Found in packages/debugger/lib/sourcemapping/selectors/index.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function walk has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function* walk(sourceId, sourceIndex, node, pointer = "", parentId = null) {
  debug("walking %s %o %o", sourceId, pointer, node);

  yield* handleEnter(sourceId, sourceIndex, node, pointer, parentId);
                          Severity: Minor
                          Found in packages/debugger/lib/ast/sagas/index.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language