Sign upLogin

truss-io/router

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Benchmark.bmbm(12) do |x|
    x.report("HTTP Router")     { TIMES.times { a.call(BLOG_POST_REQ) } }
    x.report("Usher Router")    { TIMES.times { routes.call(BLOG_POST_REQ) } }
    x.report("Truss Router")    { TIMES.times { Truss::Router.call(BLOG_POST_REQ) } }
Severity: Minor
Found in benchmarks/comparison_bench.rb and 1 other location - About 40 mins to fix
benchmarks/comparison_bench.rb on lines 25..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Benchmark.bmbm(12) do |x|
    x.report("HTTP Router")     { TIMES.times { h.call(REQUEST) } }
    x.report("Usher Router")    { TIMES.times { r.call(REQUEST) } }
    x.report("Truss Router")    { TIMES.times { Truss::Router.call(REQUEST) } }
Severity: Minor
Found in benchmarks/comparison_bench.rb and 1 other location - About 40 mins to fix
benchmarks/comparison_bench.rb on lines 73..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Benchmark.bmbm(10) do |x|
    x.report("Plain app")    { TIMES.times{ app.call(REQUEST) } }
    x.report("Last route") { TIMES.times { Truss::Router.call(HOME_REQUEST) } }
Severity: Minor
Found in benchmarks/simple_bench.rb and 3 other locations - About 20 mins to fix
benchmarks/simple_bench.rb on lines 23..25
benchmarks/simple_bench.rb on lines 70..72
benchmarks/simple_bench.rb on lines 84..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Benchmark.bmbm(11) do |x|
    x.report("Plain app")   { TIMES.times{ app.call(REQUEST) } }
    x.report("One Dynamic") { TIMES.times { Truss::Router.call(POSTS_REQUEST) } }
Severity: Minor
Found in benchmarks/simple_bench.rb and 3 other locations - About 20 mins to fix
benchmarks/simple_bench.rb on lines 23..25
benchmarks/simple_bench.rb on lines 47..49
benchmarks/simple_bench.rb on lines 70..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Benchmark.bmbm(12) do |x|
    x.report("Plain app")    { TIMES.times{ app.call(REQUEST) } }
    x.report("Single route") { TIMES.times { Truss::Router.call(REQUEST) } }
Severity: Minor
Found in benchmarks/simple_bench.rb and 3 other locations - About 20 mins to fix
benchmarks/simple_bench.rb on lines 47..49
benchmarks/simple_bench.rb on lines 70..72
benchmarks/simple_bench.rb on lines 84..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Benchmark.bmbm(10) do |x|
    x.report("Plain app")  { TIMES.times{ app.call(REQUEST) } }
    x.report("Last route") { TIMES.times { Truss::Router.call(HOME_REQUEST) } }
Severity: Minor
Found in benchmarks/simple_bench.rb and 3 other locations - About 20 mins to fix
benchmarks/simple_bench.rb on lines 23..25
benchmarks/simple_bench.rb on lines 47..49
benchmarks/simple_bench.rb on lines 84..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language