Sign upLogin

tsg-ut/mnemo

View on GitHub
Star
lib/board-component.jsx

Summary

Maintainability
F
4 days
Test Coverage

File board-component.jsx has 780 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const React = require('react');
const PropTypes = require('prop-types');
const {default: Hammer} = require('react-hammerjs');
const {INPUT_MOVE, INPUT_END} = (typeof window === 'undefined') ? {} : require('hammerjs');
const {default: Measure} = require('react-measure');
Severity: Major
Found in lib/board-component.jsx - About 1 day to fix

    BoardComponent has 48 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class BoardComponent extends React.Component {
    static propTypes = {
        status: PropTypes.string.isRequired,
        width: PropTypes.number.isRequired,
        height: PropTypes.number.isRequired,
    Severity: Minor
    Found in lib/board-component.jsx - About 6 hrs to fix

      Function render has 153 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
        return (
            <Hammer
                onPan={this.handlePan}
                onPanStart={this.handlePan}
      Severity: Major
      Found in lib/board-component.jsx - About 6 hrs to fix

        Function constructor has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            constructor(props, state) {
        super(props, state);

        // Currently, initial status should be always 'stop'
        assert(props.status === 'stop');
        Severity: Minor
        Found in lib/board-component.jsx - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                              if (this.state.selectStart !== null && this.state.selectEnd !== null) {
                        this.setState({
                            moveStatus: 'move',
                        });
                    }
          Severity: Major
          Found in lib/board-component.jsx - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            } else if (event.type === 'pan') {
                    if (this.state.moveStart !== null) {
                        this.setState({
                            moveEnd: {x: blockX, y: blockY},
                        });
            Severity: Major
            Found in lib/board-component.jsx - About 45 mins to fix

              Function componentDidUpdate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  componentDidUpdate(prevProps) {
        if (prevProps.isMovingMode && !this.props.isMovingMode) {
            this.resetMoveState();
        }
              Severity: Minor
              Found in lib/board-component.jsx - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                  if (this.isSelectedBlock(startBlockX, startBlockY)) {
                        this.setState({
                            moveStart: {x: startBlockX, y: startBlockY},
                            moveEnd: {x: startBlockX, y: startBlockY},
                        });
              Severity: Major
              Found in lib/board-component.jsx - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            offsetX: this.state.isPanning
                ? this.state.offsetX - this.state.panDistance * Math.cos(this.state.panAngle)
                : this.state.offsetX,
                Severity: Major
                Found in lib/board-component.jsx and 1 other location - About 1 hr to fix
                lib/board-component.jsx on lines 514..516

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 67.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            offsetY: this.state.isPanning
                ? this.state.offsetY - this.state.panDistance * Math.sin(this.state.panAngle)
                : this.state.offsetY,
                Severity: Major
                Found in lib/board-component.jsx and 1 other location - About 1 hr to fix
                lib/board-component.jsx on lines 511..513

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 67.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    handlePassAnimationComplete = (passEvent) => {
        if (this.passAnimationResolvers.has(passEvent)) {
            this.passAnimationResolvers.get(passEvent)();
        }
    }
                Severity: Minor
                Found in lib/board-component.jsx and 1 other location - About 40 mins to fix
                lib/block-component.jsx on lines 178..182

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            return isBetween({
                number: x,
                left: this.state.selectStart.x,
                right: this.state.selectEnd.x,
            }) && isBetween({
                Severity: Minor
                Found in lib/board-component.jsx and 1 other location - About 30 mins to fix
                lib/board-component.jsx on lines 310..314

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            }) && isBetween({
                number: y,
                left: this.state.selectStart.y,
                right: this.state.selectEnd.y,
            });
                Severity: Minor
                Found in lib/board-component.jsx and 1 other location - About 30 mins to fix
                lib/board-component.jsx on lines 306..310

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status