lib/active_zuora/persistence.rb
Method process_save
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
def process_save(zobjects, action)
unless [:create, :update].include? action
raise "Invalid action type for saving. Must be create or update."
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_save
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def process_save(zobjects, action)
unless [:create, :update].include? action
raise "Invalid action type for saving. Must be create or update."
end
Method create
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def create
return false unless new_record? && valid?
result = self.class.connection.request(:create) do |soap|
soap.body do |xml|
build_xml(xml, soap,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"