Sign upLogin

tsuz/go-pine

View on GitHub
Star

Showing 45 of 45 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func RSI(p ValueSeries, l int64) ValueSeries {
    key := fmt.Sprintf("rsi:%s:%d", p.ID(), l)
    rsi := getCache(key)
    if rsi == nil {
        rsi = NewValueSeries()
Severity: Major
Found in pine/series_rsi.go and 2 other locations - About 55 mins to fix
pine/series_ema.go on lines 8..29
pine/series_rma.go on lines 9..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getRSI has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func getRSI(stop *Value, vs ValueSeries, rsi ValueSeries, l int64) ValueSeries {

    rsiukey := fmt.Sprintf("rsiu:%s:%d", vs.ID(), l)
    rsiu := getCache(rsiukey)
    if rsiu == nil {
Severity: Minor
Found in pine/series_rsi.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getOHLCVAttr has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func getOHLCVAttr(stop OHLCV, src OHLCVSeries, dest ValueSeries, p OHLCProp) ValueSeries {

    var startt time.Time

    firstVal := dest.GetLast()
Severity: Minor
Found in pine/series_ohlcv_attr.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DMI has 8 return statements (exceeds 4 allowed).
Open

func DMI(ohlcv OHLCVSeries, len, smoo int) (adx, plus, minus ValueSeries) {
    adxkey := fmt.Sprintf("adx:%s:%d:%d", ohlcv.ID(), len, smoo)
    adx = getCache(adxkey)
    if adx == nil {
        adx = NewValueSeries()
Severity: Major
Found in pine/series_dmi.go - About 50 mins to fix

    Function MFI has 8 return statements (exceeds 4 allowed).
    Open

    func MFI(o OHLCVSeries, l int64) ValueSeries {
    key := fmt.Sprintf("mfi:%s:%d", o.ID(), l)
    mfi := getCache(key)
    if mfi == nil {
        mfi = NewValueSeries()
    Severity: Major
    Found in pine/series_mfi.go - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (s *ohlcvBaseSeries) Shift() bool {
    if s.first == nil {
        return false
    }
    delete(s.vals, s.first.S.Unix())
      Severity: Minor
      Found in pine/ohlcv_series_base.go and 1 other location - About 45 mins to fix
      pine/value_series.go on lines 178..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (s *valueSeries) Shift() bool {
    if s.first == nil {
        return false
    }
    delete(s.timemap, s.first.t.Unix())
      Severity: Minor
      Found in pine/value_series.go and 1 other location - About 45 mins to fix
      pine/ohlcv_series_base.go on lines 85..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

                          for i := 1; i < int(l)+1; i++ {
                        if prevFirstVal.prev == nil {
                            break
                        }
                        removelb++
      Severity: Major
      Found in pine/series_rsi.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if int64(removelb) == l+1 {
                        toAdd := math.Max(v.v-v.prev.v, 0)
                        remval := math.Max(prevFirstVal.next.v-prevFirstVal.v, 0)
                        newrsiu := prevr.v - remval + toAdd
                        rsiu.Set(v.t, newrsiu)
        Severity: Major
        Found in pine/series_rsi.go - About 45 mins to fix

          Method ohlcvBaseSeries.Next has 7 return statements (exceeds 4 allowed).
          Open

          func (s *ohlcvBaseSeries) Next() (*OHLCV, error) {
    if s.cur == nil {
        if len(s.vals) == 0 {
            return nil, nil
        }
          Severity: Major
          Found in pine/ohlcv_series_base.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if int64(removelb) == l+1 {
                        toAdd := math.Max(v.prev.v-v.v, 0)
                        remval := math.Max(prevFirstVal.v-prevFirstVal.next.v, 0)
                        newrsiu := prevr.v - remval + toAdd
                        rsid.Set(v.t, newrsiu)
            Severity: Major
            Found in pine/series_rsi.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  for i := 1; i < int(l)+1; i++ {
                        if prevFirstVal.prev == nil {
                            break
                        }
                        removelb++
              Severity: Major
              Found in pine/series_rsi.go - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if ct == l {
                        break
                    }
                Severity: Major
                Found in pine/series_sum.go - About 45 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      for {
        prevVal = prevVal.prev
        if prevVal == nil {
            break
        }
                  Severity: Minor
                  Found in pine/series_roc.go and 1 other location - About 40 mins to fix
                  pine/series_change.go on lines 57..75

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 110.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      for {
        prevVal = prevVal.prev
        if prevVal == nil {
            break
        }
                  Severity: Minor
                  Found in pine/series_change.go and 1 other location - About 40 mins to fix
                  pine/series_roc.go on lines 63..81

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 110.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function KC has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func KC(src ValueSeries, o OHLCVSeries, l int64, mult float64, usetr bool) (middle, upper, lower ValueSeries) {
                  Severity: Minor
                  Found in pine/series_kc.go - About 35 mins to fix

                    Function CCI has 5 return statements (exceeds 4 allowed).
                    Open

                    func CCI(tp ValueSeries, l int64) ValueSeries {
    key := fmt.Sprintf("cci:%s:%d", tp.ID(), l)
    cci := getCache(key)
    if cci == nil {
        cci = NewValueSeries()
                    Severity: Major
                    Found in pine/series_cci.go - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          u := OperateWithNil(hlc3, chg, "mfiu", func(a, b *Value) *Value {
        var v float64
        // treat nil value as HLC3
        if b == nil {
            return a
                      Severity: Minor
                      Found in pine/series_mfi.go and 1 other location - About 35 mins to fix
                      pine/series_mfi.go on lines 42..57

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 105.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function Cross has 5 return statements (exceeds 4 allowed).
                      Open

                      func Cross(a, b ValueSeries) ValueSeries {
    c := OperateWithNil(a, b, "cross", func(av, bv *Value) *Value {
        if av == nil || bv == nil {
            return nil
        }
                      Severity: Major
                      Found in pine/series_cross.go - About 35 mins to fix

                        Function change has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func change(stop Value, src, chg ValueSeries, l int) ValueSeries {

    var val *Value

    lastvw := chg.GetCurrent()
                        Severity: Minor
                        Found in pine/series_change.go - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language