Sign upLogin

tsuz/go-pine

View on GitHub
Star
pine/series_mfi.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function MFI has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func MFI(o OHLCVSeries, l int64) ValueSeries {
    key := fmt.Sprintf("mfi:%s:%d", o.ID(), l)
    mfi := getCache(key)
    if mfi == nil {
        mfi = NewValueSeries()
Severity: Minor
Found in pine/series_mfi.go - About 1 hr to fix

    Function MFI has 8 return statements (exceeds 4 allowed).
    Open

    func MFI(o OHLCVSeries, l int64) ValueSeries {
    key := fmt.Sprintf("mfi:%s:%d", o.ID(), l)
    mfi := getCache(key)
    if mfi == nil {
        mfi = NewValueSeries()
    Severity: Major
    Found in pine/series_mfi.go - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          u := OperateWithNil(hlc3, chg, "mfiu", func(a, b *Value) *Value {
        var v float64
        // treat nil value as HLC3
        if b == nil {
            return a
      Severity: Minor
      Found in pine/series_mfi.go and 1 other location - About 35 mins to fix
      pine/series_mfi.go on lines 42..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          lo := OperateWithNil(hlc3, chg, "mfil", func(a, b *Value) *Value {
        var v float64
        // treat nil value as HLC3
        if b == nil {
            return a
      Severity: Minor
      Found in pine/series_mfi.go and 1 other location - About 35 mins to fix
      pine/series_mfi.go on lines 25..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status