Sign upLogin

tsuz/go-pine

View on GitHub
Star
pine/series_rsi.go

Summary

Maintainability
D
2 days
Test Coverage

Function getRSIU has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func getRSIU(stop *Value, vs ValueSeries, rsiu ValueSeries, l int64) ValueSeries {
    firstVal := rsiu.GetLast()

    if firstVal == nil {
        firstVal = vs.GetFirst()
Severity: Minor
Found in pine/series_rsi.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRSID has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func getRSID(stop *Value, vs ValueSeries, rsid ValueSeries, l int64) ValueSeries {
    firstVal := rsid.GetLast()

    if firstVal == nil {
        firstVal = vs.GetFirst()
Severity: Minor
Found in pine/series_rsi.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRSI has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func getRSI(stop *Value, vs ValueSeries, rsi ValueSeries, l int64) ValueSeries {

    rsiukey := fmt.Sprintf("rsiu:%s:%d", vs.ID(), l)
    rsiu := getCache(rsiukey)
    if rsiu == nil {
Severity: Minor
Found in pine/series_rsi.go - About 1 hr to fix

    Function getRSIU has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func getRSIU(stop *Value, vs ValueSeries, rsiu ValueSeries, l int64) ValueSeries {
    firstVal := rsiu.GetLast()

    if firstVal == nil {
        firstVal = vs.GetFirst()
    Severity: Minor
    Found in pine/series_rsi.go - About 1 hr to fix

      Function getRSID has 63 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func getRSID(stop *Value, vs ValueSeries, rsid ValueSeries, l int64) ValueSeries {
    firstVal := rsid.GetLast()

    if firstVal == nil {
        firstVal = vs.GetFirst()
      Severity: Minor
      Found in pine/series_rsi.go - About 1 hr to fix

        Function getRSI has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
        Open

        func getRSI(stop *Value, vs ValueSeries, rsi ValueSeries, l int64) ValueSeries {

    rsiukey := fmt.Sprintf("rsiu:%s:%d", vs.ID(), l)
    rsiu := getCache(rsiukey)
    if rsiu == nil {
        Severity: Minor
        Found in pine/series_rsi.go - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                            for i := 1; i < int(l)+1; i++ {
                        if prevFirstVal.prev == nil {
                            break
                        }
                        removelb++
        Severity: Major
        Found in pine/series_rsi.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if int64(removelb) == l+1 {
                        toAdd := math.Max(v.v-v.prev.v, 0)
                        remval := math.Max(prevFirstVal.next.v-prevFirstVal.v, 0)
                        newrsiu := prevr.v - remval + toAdd
                        rsiu.Set(v.t, newrsiu)
          Severity: Major
          Found in pine/series_rsi.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if int64(removelb) == l+1 {
                        toAdd := math.Max(v.prev.v-v.v, 0)
                        remval := math.Max(prevFirstVal.v-prevFirstVal.next.v, 0)
                        newrsiu := prevr.v - remval + toAdd
                        rsid.Set(v.t, newrsiu)
            Severity: Major
            Found in pine/series_rsi.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  for i := 1; i < int(l)+1; i++ {
                        if prevFirstVal.prev == nil {
                            break
                        }
                        removelb++
              Severity: Major
              Found in pine/series_rsi.go - About 45 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                func RSI(p ValueSeries, l int64) ValueSeries {
    key := fmt.Sprintf("rsi:%s:%d", p.ID(), l)
    rsi := getCache(key)
    if rsi == nil {
        rsi = NewValueSeries()
                Severity: Major
                Found in pine/series_rsi.go and 2 other locations - About 55 mins to fix
                pine/series_ema.go on lines 8..29
                pine/series_rma.go on lines 9..30

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 126.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status