Sign upLogin

tsuz/go-pine

View on GitHub
Star
pine/series_sum.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function getSum has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func getSum(stop Value, sum ValueSeries, src ValueSeries, l int) ValueSeries {

    // keep track of the source values of sum, maximum of l+1 items
    sumSrc := make([]float64, 0)
    var startNew *Value
Severity: Minor
Found in pine/series_sum.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getSum has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func getSum(stop Value, sum ValueSeries, src ValueSeries, l int) ValueSeries {

    // keep track of the source values of sum, maximum of l+1 items
    sumSrc := make([]float64, 0)
    var startNew *Value
Severity: Minor
Found in pine/series_sum.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if ct == l {
                        break
                    }
    Severity: Major
    Found in pine/series_sum.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status