Sign upLogin

tubone24/ebook_homebrew

View on GitHub
Star
ebook_homebrew/models/rest_models.py

Summary

Maintainability
A
0 mins
Test Coverage

Too few public methods (0/2)
Invalid

class ErrorModel:
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when class has too few public methods, so be sure it's really worth it.

Too few public methods (0/2)
Invalid

class StatusModel:
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when class has too few public methods, so be sure it's really worth it.

Too few public methods (0/2)
Invalid

class ListUploadFiles:
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when class has too few public methods, so be sure it's really worth it.

Too few public methods (0/2)
Invalid

class FileNotFoundModel:
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when class has too few public methods, so be sure it's really worth it.

Too few public methods (0/2)
Invalid

class UploadModel:
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when class has too few public methods, so be sure it's really worth it.

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

class ErrorModel:
    """Error Model"""

    def __init__(self, error):
        self.error = str(error)
Severity: Minor
Found in ebook_homebrew/models/rest_models.py and 1 other location - About 50 mins to fix
ebook_homebrew/models/rest_models.py on lines 22..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

class UploadModel:
    """Upload_id Model"""

    def __init__(self, upload_id):
        self.upload_id = str(upload_id)
Severity: Minor
Found in ebook_homebrew/models/rest_models.py and 1 other location - About 50 mins to fix
ebook_homebrew/models/rest_models.py on lines 30..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Attribute name errorDate doesn't conform to snake_case naming style
Invalid

        self.errorDate = datetime.datetime.now()
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

Attribute name errorDate doesn't conform to snake_case naming style
Invalid

        self.errorDate = datetime.datetime.now()
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

Attribute name fileList doesn't conform to snake_case naming style
Invalid

        self.fileList = file_list
Severity: Info
Found in ebook_homebrew/models/rest_models.py by pylint

Used when the name doesn't conform to naming rules associated to its type (constant, variable, class...).

There are no issues that match your filters.

Category
Status