Sign upLogin

tulir/mautrix-telegram

View on GitHub
Star
mautrix_telegram/commands/portal/misc.py

Summary

Maintainability
B
6 hrs
Test Coverage

File misc.py has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# mautrix-telegram - A Matrix-Telegram puppeting bridge
# Copyright (C) 2021 Tulir Asokan
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as published by
Severity: Minor
Found in mautrix_telegram/commands/portal/misc.py - About 3 hrs to fix

    Function _parse_flag has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def _parse_flag(args: list[str]) -> tuple[str, str]:
    arg = args.pop(0).lower()
    if arg == "--":
        return "", ""
    value = ""
    Severity: Minor
    Found in mautrix_telegram/commands/portal/misc.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _parse_delta has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _parse_delta(value: str) -> timedelta | None:
    match = delta_regex.fullmatch(value)
    if not match:
        return None
    number = int(match.group(1))
    Severity: Minor
    Found in mautrix_telegram/commands/portal/misc.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return None
    Severity: Major
    Found in mautrix_telegram/commands/portal/misc.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return timedelta(seconds=number)
      Severity: Major
      Found in mautrix_telegram/commands/portal/misc.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return timedelta(minutes=number)
        Severity: Major
        Found in mautrix_telegram/commands/portal/misc.py - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status