Sign upLogin

tulir/mautrix-telegram

View on GitHub
Star
mautrix_telegram/config.py

Summary

Maintainability
C
1 day
Test Coverage

Function do_update has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def do_update(self, helper: ConfigUpdateHelper) -> None:
        super().do_update(helper)
        copy, copy_dict, base = helper

        if "appservice.protocol" in self and "appservice.address" not in self:
Severity: Major
Found in mautrix_telegram/config.py - About 5 hrs to fix

    Function do_update has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        def do_update(self, helper: ConfigUpdateHelper) -> None:
        super().do_update(helper)
        copy, copy_dict, base = helper

        if "appservice.protocol" in self and "appservice.address" not in self:
    Severity: Minor
    Found in mautrix_telegram/config.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File config.py has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # mautrix-telegram - A Matrix-Telegram puppeting bridge
# Copyright (C) 2021 Tulir Asokan
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as published by
    Severity: Minor
    Found in mautrix_telegram/config.py - About 2 hrs to fix

      Refactor this function to reduce its Cognitive Complexity from 37 to the 15 allowed.
      Open

          def do_update(self, helper: ConfigUpdateHelper) -> None:
      Severity: Critical
      Found in mautrix_telegram/config.py by sonar-python

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      There are no issues that match your filters.

      Category
      Status