Sign upLogin

tuna-timer/tuna-timer-api

View on GitHub
Star
data/timer_service_test.go

Summary

Maintainability
C
1 day
Test Coverage

File timer_service_test.go has 639 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package data

import (
    "log"
    "testing"
Severity: Minor
Found in data/timer_service_test.go - About 5 hrs to fix

    TimerServiceTestSuite has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    func (s *TimerServiceTestSuite) TestgetActiveTimer(t *testing.T) {

    now := time.Now()

    // completed
    Severity: Minor
    Found in data/timer_service_test.go - About 2 hrs to fix

      Method TimerServiceTestSuite.TestUpdateUserTimer has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (s *TimerServiceTestSuite) TestUpdateUserTimer(t *testing.T) {
    user := &models.TeamUser{
        ID:             bson.NewObjectId(),
        ExternalUserID: "user",
        TeamID:        "team",
      Severity: Minor
      Found in data/timer_service_test.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (s *TimerServiceTestSuite) SetUpSuite() {
    e := utils.NewEnvironment(utils.TestEnv, "1.0.0")

    session, err := utils.ConnectToDatabase(e.Config)
    if err != nil {
        Severity: Major
        Found in data/timer_service_test.go and 1 other location - About 1 hr to fix
        data/team_service_test.go on lines 270..284

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 146.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            newTimerData := &models.Timer{
        ID:            bson.NewObjectId(),
        TaskName:        "new-task-name",
        TeamID:            "new-team-id",
        ProjectID:        "new-project-id",
        Severity: Major
        Found in data/timer_service_test.go and 1 other location - About 1 hr to fix
        data/timer_service_test.go on lines 563..577

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 139.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            newTimerData := &models.Timer{
        ID:            bson.NewObjectId(),
        TaskName:        "new-task-name",
        TeamID:            "new-team-id",
        ProjectID:        "new-project-id",
        Severity: Major
        Found in data/timer_service_test.go and 1 other location - About 1 hr to fix
        data/timer_service_test.go on lines 464..478

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 139.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status