Sign upLogin

tuomas2/serviceform

View on GitHub
Star
serviceform/tasks/models.py

Summary

Maintainability
A
35 mins
Test Coverage
B
88%

Cyclomatic complexity is too high in method execute. (6)
Open

    def execute(self):
        if self.status != self.REQUESTED:
            logger.warning('Task %s status was not REQUESTED but %s', self, self.status)
            return
        args, kwargs = json.loads(self.data)
Severity: Minor
Found in serviceform/tasks/models.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function make has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def make(cls, method: Callable, *args, scheduled_time: 'datetime'=None, **kwargs):
Severity: Minor
Found in serviceform/tasks/models.py - About 35 mins to fix

    No newline at end of file
    Open

            self.save()
    Severity: Minor
    Found in serviceform/tasks/models.py by pep8

    Trailing blank lines are superfluous.

    Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

    Missing whitespace around parameter equals
    Open

        def make(cls, method: Callable, *args, scheduled_time: 'datetime'=None, **kwargs):
    Severity: Minor
    Found in serviceform/tasks/models.py by pep8

    Don't use spaces around the '=' sign in function arguments.

    Don't use spaces around the '=' sign when used to indicate a
keyword argument or a default parameter value, except when
using a type annotation.

Okay: def complex(real, imag=0.0):
Okay: return magic(r=real, i=imag)
Okay: boolean(a == b)
Okay: boolean(a != b)
Okay: boolean(a <= b)
Okay: boolean(a >= b)
Okay: def foo(arg: int = 42):
Okay: async def foo(arg: int = 42):

E251: def complex(real, imag = 0.0):
E251: return magic(r = real, i = imag)
E252: def complex(real, image: float=0.0):

    Missing whitespace around parameter equals
    Open

        def make(cls, method: Callable, *args, scheduled_time: 'datetime'=None, **kwargs):
    Severity: Minor
    Found in serviceform/tasks/models.py by pep8

    Don't use spaces around the '=' sign in function arguments.

    Don't use spaces around the '=' sign when used to indicate a
keyword argument or a default parameter value, except when
using a type annotation.

Okay: def complex(real, imag=0.0):
Okay: return magic(r=real, i=imag)
Okay: boolean(a == b)
Okay: boolean(a != b)
Okay: boolean(a <= b)
Okay: boolean(a >= b)
Okay: def foo(arg: int = 42):
Okay: async def foo(arg: int = 42):

E251: def complex(real, imag = 0.0):
E251: return magic(r = real, i = imag)
E252: def complex(real, image: float=0.0):

    There are no issues that match your filters.

    Category
    Status