turboladen/pants

View on GitHub

Showing 8 of 8 total issues

Method remove_writer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def remove_writer(obj, key_value_pairs=nil)
        if obj.is_a? Class
          @writers.delete_if do |writer|
            writer.is_a?(obj) &&
              key_value_pairs.all? { |k, v| writer.send(k) == v }
Severity: Minor
Found in lib/pants/readers/base_reader.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post_init has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def post_init
        @read_from_channel.subscribe do |data|
          if data.size > PACKET_SPLIT_THRESHOLD
            log "#{__id__} Got big data: #{data.size}.  Splitting..."
            io = StringIO.new(data)
Severity: Minor
Found in lib/pants/writers/udp_writer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def start
        log "#{__id__} Adding a #{self.class} to write to #{@file_path}"

        EM.defer do
          @read_from_channel.subscribe do |data|
Severity: Minor
Found in lib/pants/writers/file_writer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove_writer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def remove_writer(obj, key_value_pairs=nil)
        if obj.is_a? Class
          @writers.delete_if do |writer|
            writer.is_a?(obj) &&
              key_value_pairs.all? { |k, v| writer.send(k) == v }
Severity: Minor
Found in lib/pants/readers/base_reader.rb - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      DEFAULT_URI_TO_READER_MAP = [
        { uri_scheme: nil, klass: Pants::Readers::FileReader, args: [:path] },
        { uri_scheme: 'file', klass: Pants::Readers::FileReader, args: [:path] },
        { uri_scheme: 'udp', klass: Pants::Readers::UDPReader, args: [:host, :port] }
      ]
    Severity: Minor
    Found in lib/pants.rb and 1 other location - About 30 mins to fix
    lib/pants.rb on lines 18..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      DEFAULT_URI_TO_WRITER_MAP = [
        { uri_scheme: nil, klass: Pants::Writers::FileWriter, args: [:path] },
        { uri_scheme: 'file', klass: Pants::Writers::FileWriter, args: [:path] },
        { uri_scheme: 'udp', klass: Pants::Writers::UDPWriter, args: [:host, :port] }
      ]
    Severity: Minor
    Found in lib/pants.rb and 1 other location - About 30 mins to fix
    lib/pants.rb on lines 12..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method new_reader_from_uri has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def new_reader_from_uri(uri, callback)
          reader_to_use = if uri.nil?
            Pants.readers.find { |reader| reader[:uri_scheme].nil? }
          else
            Pants.readers.find { |reader| reader[:uri_scheme] == uri.scheme }
    Severity: Minor
    Found in lib/pants/core.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method stopper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def stopper
            return @stopper if @stopper
    
            @stopper = EM.Callback do
              log "Got called back after finished reading.  Starting shutdown..."
    Severity: Minor
    Found in lib/pants/readers/base_reader.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language