Sign upLogin

turboladen/pants

View on GitHub
Star

Showing 6 of 8 total issues

Method remove_writer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def remove_writer(obj, key_value_pairs=nil)
        if obj.is_a? Class
          @writers.delete_if do |writer|
            writer.is_a?(obj) &&
              key_value_pairs.all? { |k, v| writer.send(k) == v }
Severity: Minor
Found in lib/pants/readers/base_reader.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post_init has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def post_init
        @read_from_channel.subscribe do |data|
          if data.size > PACKET_SPLIT_THRESHOLD
            log "#{__id__} Got big data: #{data.size}.  Splitting..."
            io = StringIO.new(data)
Severity: Minor
Found in lib/pants/writers/udp_writer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def start
        log "#{__id__} Adding a #{self.class} to write to #{@file_path}"

        EM.defer do
          @read_from_channel.subscribe do |data|
Severity: Minor
Found in lib/pants/writers/file_writer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove_writer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def remove_writer(obj, key_value_pairs=nil)
        if obj.is_a? Class
          @writers.delete_if do |writer|
            writer.is_a?(obj) &&
              key_value_pairs.all? { |k, v| writer.send(k) == v }
Severity: Minor
Found in lib/pants/readers/base_reader.rb - About 1 hr to fix

    Method stopper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def stopper
        return @stopper if @stopper

        @stopper = EM.Callback do
          log "Got called back after finished reading.  Starting shutdown..."
    Severity: Minor
    Found in lib/pants/readers/base_reader.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_reader_from_uri has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def new_reader_from_uri(uri, callback)
      reader_to_use = if uri.nil?
        Pants.readers.find { |reader| reader[:uri_scheme].nil? }
      else
        Pants.readers.find { |reader| reader[:uri_scheme] == uri.scheme }
    Severity: Minor
    Found in lib/pants/core.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language