Sign upLogin

turboladen/tailor

View on GitHub
Star
lib/tailor/rulers/spaces_after_lbrace_ruler.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method count_spaces has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def count_spaces(lexed_line, column)
        event_index = lexed_line.event_index(column)

        if event_index.nil?
          log 'No lbrace in this line.  Moving on...'
Severity: Minor
Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb - About 1 hr to fix

    Method check_spaces_after_lbrace has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_spaces_after_lbrace(lexed_line, lineno)
        log "lbraces found at: #{@lbrace_columns}" unless @lbrace_columns.empty?

        @lbrace_columns.each do |column|
          actual_spaces = count_spaces(lexed_line, column)
    Severity: Minor
    Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method count_spaces has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def count_spaces(lexed_line, column)
        event_index = lexed_line.event_index(column)

        if event_index.nil?
          log 'No lbrace in this line.  Moving on...'
    Severity: Minor
    Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method comment_update has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def comment_update(token, lexed_line, _, lineno, column)
    Severity: Minor
    Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

                return next_event.last.size
      Severity: Major
      Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb - About 30 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              def check_spaces_after_lbrace(lexed_line, lineno)
        log "lbraces found at: #{@lbrace_columns}" unless @lbrace_columns.empty?

        @lbrace_columns.each do |column|
          actual_spaces = count_spaces(lexed_line, column)
        Severity: Minor
        Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb and 2 other locations - About 35 mins to fix
        lib/tailor/rulers/spaces_after_lbracket_ruler.rb on lines 53..71
        lib/tailor/rulers/spaces_after_lparen_ruler.rb on lines 47..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

              def measure(actual_spaces, lineno, column)
        if actual_spaces != @config
          msg = "Line has #{actual_spaces} space(s) after a {, "
          msg << "but should have #{@config}."
        Severity: Major
        Found in lib/tailor/rulers/spaces_after_lbrace_ruler.rb and 4 other locations - About 25 mins to fix
        lib/tailor/rulers/spaces_after_comma_ruler.rb on lines 42..48
        lib/tailor/rulers/spaces_after_lbracket_ruler.rb on lines 43..49
        lib/tailor/rulers/spaces_after_lparen_ruler.rb on lines 37..43
        lib/tailor/rulers/spaces_before_comma_ruler.rb on lines 31..37

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status