Sign upLogin

tushar2708/conveyor

View on GitHub
Star
examples/squaring_numbers/prepare_conveyor.go

Summary

Maintainability
A
0 mins
Test Coverage

Function PrepareComplexTransactionalConveyor has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Wontfix

func PrepareComplexTransactionalConveyor(cnv *conveyor.Conveyor) (*conveyor.Conveyor, error) {

    gen := &NumberSource{
        ConcreteNodeExecutor: &conveyor.ConcreteNodeExecutor{
            Name: "number_generator",
Severity: Minor
Found in examples/squaring_numbers/prepare_conveyor.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

    func PrepareLoopingConveyor(cnv *conveyor.Conveyor) (*conveyor.Conveyor, error) {

    // Create a source executor, and add it to conveyor.
    // A pipeline may have only one source node
    gen := &NumberSource{
    Severity: Major
    Found in examples/squaring_numbers/prepare_conveyor.go and 1 other location - About 3 hrs to fix
    examples/squaring_numbers/prepare_conveyor.go on lines 60..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 275.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

    func PrepareTransactionalConveyor(cnv *conveyor.Conveyor) (*conveyor.Conveyor, error) {

    gen := &NumberSource{
        ConcreteNodeExecutor: &conveyor.ConcreteNodeExecutor{Name: "number_generator"},
        CountLimit:           20,
    Severity: Major
    Found in examples/squaring_numbers/prepare_conveyor.go and 1 other location - About 3 hrs to fix
    examples/squaring_numbers/prepare_conveyor.go on lines 19..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 275.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    don't use MixedCaps in package name; squaringNumbers should be squaringnumbers
    Open

    package squaringNumbers
    Severity: Minor
    Found in examples/squaring_numbers/prepare_conveyor.go by golint

    There are no issues that match your filters.

    Category
    Status