Sign upLogin

tutorbookapp/tutorbook

View on GitHub
Star
lib/model/user.ts

Summary

Maintainability
C
1 day
Test Coverage

Function isUserJSON has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

export function isUserJSON(json: unknown): json is UserJSON {
  if (!isAccountJSON(json)) return false;
  if (!isJSON(json)) return false;
  if (json.age && typeof json.age !== 'number') return false;
  if (!isStringArray(json.orgs)) return false;
Severity: Minor
Found in lib/model/user.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  if (!isAvailabilityJSON(json.availability)) return false;
Severity: Major
Found in lib/model/user.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return true;
    Severity: Major
    Found in lib/model/user.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (!isArray(json.subjects, isSubject)) return false;
      Severity: Major
      Found in lib/model/user.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (!isArray(json.meetings, isMeetingJSON)) return false;
        Severity: Major
        Found in lib/model/user.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if (typeof json.timezone !== 'string') return false;
          Severity: Major
          Found in lib/model/user.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (!isStringArray(json.langs)) return false;
            Severity: Major
            Found in lib/model/user.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                if (json.hash && typeof json.hash !== 'string') return false;
              Severity: Major
              Found in lib/model/user.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  if (typeof json.reference !== 'string') return false;
                Severity: Major
                Found in lib/model/user.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    if (!isArray(json.tags, isUserTag)) return false;
                  Severity: Major
                  Found in lib/model/user.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      if (json.token && typeof json.token !== 'string') return false;
                    Severity: Major
                    Found in lib/model/user.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        if (!isStringArray(json.parents)) return false;
                      Severity: Major
                      Found in lib/model/user.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                          if (typeof json.visible !== 'boolean') return false;
                        Severity: Major
                        Found in lib/model/user.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            if (!isArray(json.roles, isRole)) return false;
                          Severity: Major
                          Found in lib/model/user.ts - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  subjects: 'subjects' in record ? (record.subjects || []).map((s) => ({ name: s.name, id: s.id })) : [],
                            Severity: Major
                            Found in lib/model/user.ts and 1 other location - About 1 hr to fix
                            lib/model/meeting.ts on lines 203..203

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 56.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status