Sign upLogin

tutugodfrey/modela

View on GitHub
Star

Showing 42 of 42 total issues

Function findById has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function findById(id: number | string, returnFields=[]) {
  const result = new Promise((resolve, reject) => {
    if (!id) reject({ message: 'Expected argument 1 to be id of model to search' });
    if (!Array.isArray(returnFields))
      reject({ message: 'Expected an array of fields to return' });
Severity: Minor
Found in src/main/methods/findById.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

    if ((!checkAll && !checkObjType) ||
       (!checkAll && !checkWhere) ||
       (checkWhere && !checkWhereKeys)) {
        if (checkLimit) {
          // pass if limit is provided
Severity: Major
Found in src/main/methods/findAll.ts - About 40 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            this.allowedFields.forEach(function (field) {
            if (schema[field].unique)
                return _this.uniqueKeys.push(field);
        });
    Severity: Minor
    Found in src/main/DataModela.js and 1 other location - About 40 mins to fix
    src/main/DataModela.js on lines 70..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            this.allowedFields.forEach(field => {
            if (schema[field].required) return this.requiredFields.push(field);
        });
    Severity: Minor
    Found in src/main/DataModela.ts and 1 other location - About 40 mins to fix
    src/main/DataModela.ts on lines 87..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            this.allowedFields.forEach(function (field) {
            if (schema[field].required)
                return _this.requiredFields.push(field);
        });
    Severity: Minor
    Found in src/main/DataModela.js and 1 other location - About 40 mins to fix
    src/main/DataModela.js on lines 74..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            this.allowedFields.forEach(field => {
            if (schema[field].unique) return this.uniqueKeys.push(field);
        });
    Severity: Minor
    Found in src/main/DataModela.ts and 1 other location - About 40 mins to fix
    src/main/DataModela.ts on lines 83..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function createModelWithDB has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function createModelWithDB(this: any, 
  modelToCreate: any,
  returnFields: Array<any>,
  resolve: Function,
  reject: Function
    Severity: Minor
    Found in src/main/methods/create.ts - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const key = err.detail.split('=')[0].split('(')[1].split(')')[0];
      Severity: Minor
      Found in src/main/methods/create.ts and 1 other location - About 35 mins to fix
      src/main/methods/create.ts on lines 149..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const value = err.detail.split('=')[1].split(')')[0].split('(')[1];
      Severity: Minor
      Found in src/main/methods/create.ts and 1 other location - About 35 mins to fix
      src/main/methods/create.ts on lines 148..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function find has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function find(condition: Condition, returnFields=[]) {
  /* return a single object that meet the condition
    condition is single object with property where whose value is further
    an object with key => value pair of the properties of the object to find
  */
      Severity: Minor
      Found in src/main/methods/find.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                    return true;
      Severity: Major
      Found in src/main/helpers/functs.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return createModelWithDB(prepareDataForStorage(modelToCreate, schema), returnFields, resolve, reject);
        Severity: Major
        Found in src/main/methods/create.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return true;
          Severity: Major
          Found in src/main/helpers/functs.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return createModel(modelToCreate, returnFields, resolve, reject);
            Severity: Major
            Found in src/main/methods/create.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return result;
              Severity: Major
              Found in src/main/methods/bulkCreate.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false;
                Severity: Major
                Found in src/main/helpers/functs.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return false;
                  Severity: Major
                  Found in src/main/helpers/functs.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                              return true;
                    Severity: Major
                    Found in src/main/helpers/functs.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                return true;
                      Severity: Major
                      Found in src/main/helpers/functs.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return false
                        Severity: Major
                        Found in src/main/helpers/functs.ts - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language