Sign upLogin

tutugodfrey/modela

View on GitHub
Star
src/main/helpers/functs.ts

Summary

Maintainability
F
5 days
Test Coverage

Function checkDatatype has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  checkDatatype: (schema: object, modelToCreate: object) => {
    // Return datatype fields that fail validation and a message
    const allowedFields = Object.keys(schema);
    let datatypeValidationMessage = '';
    const datatypeField = allowedFields.find(field => {
Severity: Minor
Found in src/main/helpers/functs.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File functs.ts has 322 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Condition, IMapping } from '../interfaces';

const functObj = {
  confirmPropMatch: (model: IMapping, conditions: Condition) => {
    const whereConditions: IMapping = conditions.where;
Severity: Minor
Found in src/main/helpers/functs.ts - About 3 hrs to fix

    Function confirmPropMatch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      confirmPropMatch: (model: IMapping, conditions: Condition) => {
    const whereConditions: IMapping = conditions.where;
    const groupConditions = conditions.groups ? conditions.groups : null;
    const props = Object.keys(whereConditions);
    const matchType = conditions.type ? conditions.type : 'and';
    Severity: Minor
    Found in src/main/helpers/functs.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                  if (field === 'createdAt' || field === 'updatedAt') {
                // This field will be supplied at creation time if not provided
                return false;
              }
    Severity: Major
    Found in src/main/helpers/functs.ts - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

                    return true;
      Severity: Major
      Found in src/main/helpers/functs.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return true;
        Severity: Major
        Found in src/main/helpers/functs.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return false;
          Severity: Major
          Found in src/main/helpers/functs.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return false;
            Severity: Major
            Found in src/main/helpers/functs.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                        return true;
              Severity: Major
              Found in src/main/helpers/functs.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return true;
                Severity: Major
                Found in src/main/helpers/functs.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return false
                  Severity: Major
                  Found in src/main/helpers/functs.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                              return false;
                    Severity: Major
                    Found in src/main/helpers/functs.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                return true;
                      Severity: Major
                      Found in src/main/helpers/functs.ts - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              } else {
        if ([ 'timestamp', 'timestampz' ].includes(fieldDataType)) {
          if (typeof propValue === 'number') {
            propString = `${propString}, "${prop}" = (SELECT to_timestamp(${propValue}))`;
          } else {
                        Severity: Major
                        Found in src/main/helpers/functs.ts and 1 other location - About 7 hrs to fix
                        src/main/helpers/functs.ts on lines 199..211

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 183.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              if (propString === '') {
        if ([ 'timestamp', 'timestampz' ].includes(fieldDataType)) {
          if (typeof propValue === 'number') {
            propString = `${propString}"${prop}" = (SELECT to_timestamp(${propValue}))`;
          } else {
                        Severity: Major
                        Found in src/main/helpers/functs.ts and 1 other location - About 7 hrs to fix
                        src/main/helpers/functs.ts on lines 211..223

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 183.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if (Array.isArray(whereProp )) {
          let str = '';
          const matchValue = whereProp;
          matchValue.forEach(value => str = !str ? `(${str} "${prop}" = '${value}'` : `${str} OR "${prop}" = '${value}'`);
          groupStr = groupStr ? `${groupStr} ${type} ${str}` : `${str}`;
                        Severity: Major
                        Found in src/main/helpers/functs.ts and 1 other location - About 4 hrs to fix
                        src/main/helpers/functs.ts on lines 172..182

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 118.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              if (Array.isArray(whereProp )) {
        let str = '';
        const matchValue = whereProp;
        matchValue.forEach(value => str = !str ? 
          `${str} "${prop}" = '${value}'` : `${str} OR "${prop}" = '${value}'`);
                        Severity: Major
                        Found in src/main/helpers/functs.ts and 1 other location - About 4 hrs to fix
                        src/main/helpers/functs.ts on lines 151..160

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 118.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                groupsPassingState[index] = !groupProps.find((prop) => {
          const wherePropValues = whereConditions[prop];
          const fieldValue = model[prop];
          if (Array.isArray(wherePropValues))
            return wherePropValues.includes(fieldValue);
                        Severity: Major
                        Found in src/main/helpers/functs.ts and 1 other location - About 1 hr to fix
                        src/main/helpers/functs.ts on lines 24..30

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              const result = props.find((prop) => {
        const wherePropValues = whereConditions[prop];
        const fieldValue = model[prop]
        if (Array.isArray(wherePropValues))
          return (wherePropValues.includes(fieldValue));
                        Severity: Major
                        Found in src/main/helpers/functs.ts and 1 other location - About 1 hr to fix
                        src/main/helpers/functs.ts on lines 12..18

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status