twada/espower

View on GitHub

Showing 47 of 47 total issues

Function createVisitor has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

  createVisitor (ast) {
    verifyAstPrerequisites(ast, this.options);
    const that = this;
    let assertionVisitor;
    const storage = {};
Severity: Minor
Found in lib/instrumentor.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createVisitor has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  createVisitor (ast) {
    verifyAstPrerequisites(ast, this.options);
    const that = this;
    let assertionVisitor;
    const storage = {};
Severity: Major
Found in lib/instrumentor.js - About 3 hrs to fix

    Function exports has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function () {
      const isPromiseLike = (o) => o !== null &&
                    typeof o === 'object' &&
                    typeof o.then === 'function' &&
                    typeof o.catch === 'function';
    Severity: Major
    Found in templates/argument-recorder.js - About 3 hrs to fix

      File assertion-visitor.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';
      
      const pkg = require('../package.json');
      const { ArgumentModification, NoModification } = require('./argument-modification');
      const { createNewAssertionMessage, NodeCreator, getOrCreateNode, findBlockedScope, findEspathOfAncestorNode, insertAfterUseStrictDirective } = require('./create-node');
      Severity: Minor
      Found in lib/assertion-visitor.js - About 3 hrs to fix

        Function defaultOptions has 76 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const defaultOptions = () => {
          return {
            ecmaVersion: 2018,
            sourceType: 'module',
            patterns: [
        Severity: Major
        Found in lib/default-options.js - About 3 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              transformation.register(scopeBlockEspath, (matchNode) => {
                let body;
                if (/Function/.test(matchNode.type)) {
                  const blockStatement = matchNode.body;
                  body = blockStatement.body;
          Severity: Major
          Found in lib/assertion-visitor.js and 1 other location - About 2 hrs to fix
          lib/create-node.js on lines 23..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            transformation.register(scopeBlockEspath, (matchNode) => {
              let body;
              if (/Function/.test(matchNode.type)) {
                const blockStatement = matchNode.body;
                body = blockStatement.body;
          Severity: Major
          Found in lib/create-node.js and 1 other location - About 2 hrs to fix
          lib/assertion-visitor.js on lines 248..257

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function exports has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function () {
            const isPromiseLike = (o) => o !== null &&
                          typeof o === 'object' &&
                          typeof o.then === 'function' &&
                          typeof o.catch === 'function';
          Severity: Minor
          Found in templates/argument-recorder.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function valueToNode has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

            valueToNode (value) {
              // undefined
              if (value === undefined) {
                return this.identifier('undefined');
              }
          Severity: Minor
          Found in lib/create-node-with-loc.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function generateMetadataGenerator has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            generateMetadataGenerator (controller) {
              const options = this.options;
              const types = new NodeCreator(options.globalScope.block);
              const generateNode = () => {
                const patternIndexIdent = types.identifier('ptnidx');
          Severity: Minor
          Found in lib/assertion-visitor.js - About 1 hr to fix

            Function createPatternMatchers has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

            const createPatternMatchers = (options) => {
              return options.patterns.map((p, index) => {
                const pattern = typeof p === 'string' ? p : p.pattern;
                const parsed = signature.parse(pattern);
                let matcher;
            Severity: Minor
            Found in lib/create-pattern-matchers.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function generateMetadata has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              generateMetadata (controller) {
                const currentNode = controller.current();
                const transformation = this.options.transformation;
                const types = new NodeCreator(currentNode);
                const props = {};
            Severity: Minor
            Found in lib/assertion-visitor.js - About 1 hr to fix

              Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function () {
                const _s = '\n\n      ';
              
                class AssertionMessage {
                  /**
              Severity: Minor
              Found in templates/assertion-message.js - About 1 hr to fix

                Function generateNode has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    const generateNode = () => {
                      const patternIndexIdent = types.identifier('ptnidx');
                      const contentIdent = types.identifier('content');
                      const lineIdent = types.identifier('line');
                      const extraIdent = types.identifier('extra');
                Severity: Minor
                Found in lib/assertion-visitor.js - About 1 hr to fix

                  Function leave has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        leave: function (currentNode, parentNode) {
                          try {
                            const controller = this;
                            const path = controller.path();
                            const espath = path ? path.join('/') : '';
                  Severity: Minor
                  Found in lib/instrumentor.js - About 1 hr to fix

                    Function _rec has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        _rec (value, espath) {
                          const empowered = this._callee && this._callee._empowered;
                          try {
                            if (!empowered) return value;
                            if (!espath) return this;
                    Severity: Minor
                    Found in templates/argument-recorder.js - About 1 hr to fix

                      Function valueToNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        valueToNode (value) {
                          // undefined
                          if (value === undefined) {
                            return this.identifier('undefined');
                          }
                      Severity: Minor
                      Found in lib/create-node-with-loc.js - About 1 hr to fix

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                              {
                                pattern: 'assert.deepEqual(actual, expected, [message])',
                                params: [
                                  { name: 'actual', options: { maxDepth: 2 } },
                                  { name: 'expected', options: { maxDepth: 2 } },
                        Severity: Major
                        Found in lib/default-options.js and 3 other locations - About 1 hr to fix
                        lib/default-options.js on lines 22..29
                        lib/default-options.js on lines 30..37
                        lib/default-options.js on lines 38..45

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 61.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                              {
                                pattern: 'assert.notDeepEqual(actual, expected, [message])',
                                params: [
                                  { name: 'actual', options: { maxDepth: 2 } },
                                  { name: 'expected', options: { maxDepth: 2 } },
                        Severity: Major
                        Found in lib/default-options.js and 3 other locations - About 1 hr to fix
                        lib/default-options.js on lines 14..21
                        lib/default-options.js on lines 30..37
                        lib/default-options.js on lines 38..45

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 61.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                              {
                                pattern: 'assert.deepStrictEqual(actual, expected, [message])',
                                params: [
                                  { name: 'actual', options: { maxDepth: 2 } },
                                  { name: 'expected', options: { maxDepth: 2 } },
                        Severity: Major
                        Found in lib/default-options.js and 3 other locations - About 1 hr to fix
                        lib/default-options.js on lines 14..21
                        lib/default-options.js on lines 22..29
                        lib/default-options.js on lines 38..45

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 61.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language