Sign upLogin

twada/espower

View on GitHub
Star
lib/assertion-visitor.js

Summary

Maintainability
C
1 day
Test Coverage

File assertion-visitor.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const pkg = require('../package.json');
const { ArgumentModification, NoModification } = require('./argument-modification');
const { createNewAssertionMessage, NodeCreator, getOrCreateNode, findBlockedScope, findEspathOfAncestorNode, insertAfterUseStrictDirective } = require('./create-node');
Severity: Minor
Found in lib/assertion-visitor.js - About 3 hrs to fix

    Function generateMetadataGenerator has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      generateMetadataGenerator (controller) {
    const options = this.options;
    const types = new NodeCreator(options.globalScope.block);
    const generateNode = () => {
      const patternIndexIdent = types.identifier('ptnidx');
    Severity: Minor
    Found in lib/assertion-visitor.js - About 1 hr to fix

      Function generateMetadata has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        generateMetadata (controller) {
    const currentNode = controller.current();
    const transformation = this.options.transformation;
    const types = new NodeCreator(currentNode);
    const props = {};
      Severity: Minor
      Found in lib/assertion-visitor.js - About 1 hr to fix

        Function generateNode has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const generateNode = () => {
      const patternIndexIdent = types.identifier('ptnidx');
      const contentIdent = types.identifier('content');
      const lineIdent = types.identifier('line');
      const extraIdent = types.identifier('extra');
        Severity: Minor
        Found in lib/assertion-visitor.js - About 1 hr to fix

          Function appendMessage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            appendMessage (controller) {
    const currentNode = controller.current();
    if (this.messageUpdated) {
      // AssertionMessage is already merged with existing message argument
      return currentNode;
          Severity: Minor
          Found in lib/assertion-visitor.js - About 1 hr to fix

            Function appendMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              appendMessage (controller) {
    const currentNode = controller.current();
    if (this.messageUpdated) {
      // AssertionMessage is already merged with existing message argument
      return currentNode;
            Severity: Minor
            Found in lib/assertion-visitor.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                transformation.register(scopeBlockEspath, (matchNode) => {
      let body;
      if (/Function/.test(matchNode.type)) {
        const blockStatement = matchNode.body;
        body = blockStatement.body;
            Severity: Major
            Found in lib/assertion-visitor.js and 1 other location - About 2 hrs to fix
            lib/create-node.js on lines 23..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            const isPathIdentical = (path1, path2) => {
  return path1 && path2 && path1.join('/') === path2.join('/');
};
            Severity: Minor
            Found in lib/assertion-visitor.js and 1 other location - About 30 mins to fix
            lib/argument-modification.js on lines 104..106

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status