tweetstream/em-twitter

View on GitHub

Showing 8 of 8 total issues

Class Connection has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Connection < EM::Connection

      STALL_TIMEOUT   = 90 unless defined?(STALL_TIMEOUT)
      STALL_TIMER     = 10 unless defined?(STALL_TIMER)

Severity: Minor
Found in lib/em-twitter/connection.rb - About 3 hrs to fix

    Class Request has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Request
    
          attr_reader :proxy, :options
    
          def initialize(options = {})
    Severity: Minor
    Found in lib/em-twitter/request.rb - About 2 hrs to fix

      Method ssl_verify_peer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def ssl_verify_peer(cert_string)
              cert = nil
              begin
                cert = OpenSSL::X509::Certificate.new(cert_string)
              rescue OpenSSL::X509::CertificateError
      Severity: Minor
      Found in lib/em-twitter/connection.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_s has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def to_s
              content = query
      
              data = []
              data << "#{request_method} #{request_uri} HTTP/1.1"
      Severity: Minor
      Found in lib/em-twitter/request.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method params has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def params
              flat = {}
              @options[:params].each do |param, val|
                next if val.to_s.empty? || (val.respond_to?(:empty?) && val.empty?)
                val = val.join(",") if val.respond_to?(:join)
      Severity: Minor
      Found in lib/em-twitter/request.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method concat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def concat(data)
              @timestamp = Time.now
      
              return unless data && data.size > 0
      
      
      Severity: Minor
      Found in lib/em-twitter/response.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def increment
                if maximum_reconnects?
                  raise EM::Twitter::ReconnectLimitError.new("#{@reconnect_count} Reconnects")
                end
      
      
      Severity: Minor
      Found in lib/em-twitter/reconnectors/network_failure.rb and 1 other location - About 15 mins to fix
      lib/em-twitter/reconnectors/application_failure.rb on lines 25..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def increment
                if maximum_reconnects?
                  raise EM::Twitter::ReconnectLimitError.new("#{@reconnect_count} Reconnects")
                end
      
      
      Severity: Minor
      Found in lib/em-twitter/reconnectors/application_failure.rb and 1 other location - About 15 mins to fix
      lib/em-twitter/reconnectors/network_failure.rb on lines 25..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language