Sign upLogin

twitter/twitter-cldr-rb

View on GitHub
Star
lib/twitter_cldr/timezones/generic_location.rb

Summary

Maintainability
C
1 day
Test Coverage

Method format_display_name has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

      def format_display_name(date, type, fmt, dst = TZInfo::Timezone.default_dst, &block)
        date_int = date.strftime('%s').to_i
        period = tz.period_for_local(date, dst, &block)

        flavor = if type == :generic
Severity: Minor
Found in lib/twitter_cldr/timezones/generic_location.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method format_display_name has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def format_display_name(date, type, fmt, dst = TZInfo::Timezone.default_dst, &block)
        date_int = date.strftime('%s').to_i
        period = tz.period_for_local(date, dst, &block)

        flavor = if type == :generic
Severity: Minor
Found in lib/twitter_cldr/timezones/generic_location.rb - About 1 hr to fix

    Method format_display_name has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def format_display_name(date, type, fmt, dst = TZInfo::Timezone.default_dst, &block)
    Severity: Minor
    Found in lib/twitter_cldr/timezones/generic_location.rb - About 35 mins to fix

      Method partial_location_name_for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def partial_location_name_for(metazone, mz_name)
        region_code = ZoneMeta.canonical_country_for(tz_id)

        location = if region_code
          if region_code == metazone.reference_region_code
      Severity: Minor
      Found in lib/twitter_cldr/timezones/generic_location.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                    return mz_name
      Severity: Major
      Found in lib/twitter_cldr/timezones/generic_location.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return mz_name
        Severity: Major
        Found in lib/twitter_cldr/timezones/generic_location.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                        return partial_location_name_for(tz_metazone.metazone, mz_name)
          Severity: Major
          Found in lib/twitter_cldr/timezones/generic_location.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status