Sign upLogin

twitterdev/twitter-ruby-ads-sdk

View on GitHub
Star
examples/metric_filtering.rb

Summary

Maintainability
A
3 hrs
Test Coverage

File metric_filtering.rb has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'twitter-ads'
require 'yaml'

module TwitterAds
Severity: Minor
Found in examples/metric_filtering.rb - About 2 hrs to fix

    Method filter_placements has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def filter_placements(metrics, placements)
      # return, nothing to exclude
      return if placements.include?(:all_on_twitter) && placements.include?(:publisher_network)

      # remove all TAP-related metrics unless publisher_network
    Severity: Minor
    Found in examples/metric_filtering.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status