Sign upLogin

twitterdev/twitter-ruby-ads-sdk

View on GitHub
Star
lib/twitter-ads/creative/cards_fetch.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method load has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def load(account, card_uris = nil, card_id = nil, with_deleted = nil, opts = {})
        if (card_uris && card_id) || (card_uris.nil? && card_id.nil?)
          raise ArgumentError.new('card_uris and card_id are exclusive parameters. ' \
                             'Please supply one or the other, but not both.')
        end
Severity: Minor
Found in lib/twitter-ads/creative/cards_fetch.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def load(account, card_uris = nil, card_id = nil, with_deleted = nil, opts = {})
Severity: Minor
Found in lib/twitter-ads/creative/cards_fetch.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status