Sign upLogin

twschiller/open-synthesis

View on GitHub
Star
openach/digest.py

Summary

Maintainability
A
1 hr
Test Coverage

Function send_digest_emails has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def send_digest_emails(digest_frequency):
    """Send daily digests to users subscribed to digests with frequency digest_frequency.

    :return tuple containing number of emails successfully sent and number that failed to send
    """
Severity: Minor
Found in openach/digest.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function notification_digest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def notification_digest(user, start, end):
    """Return digest for user with content/notifications occurring after start.

    Notifications are grouped by target, e.g., board.
Severity: Minor
Found in openach/digest.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status