uPortal-Project/uportal-home

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      layoutService.getGuestMode().then(function(guest) {
        $scope.guestMode = guest;
        return guest;
      }).catch(function() {
        $log.warn('could not retrieve guest mode');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        layoutService.getGuestMode().then(function(result) {
          $scope.guestMode = result;
          return result;
        })
        .catch(function() {

• Read up
  Read up

Function addToHome has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        $scope.addToHome = function addToHome(portlet) {
          var fname = portlet.fname;
          var ret = layoutService.addToHome(portlet, $sessionStorage.layout);
          ret.then(
            function successCallback(response) {

Function addToHome has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

       $scope.addToHome = function addToHome(portlet) {
        console.log("market: portlet", portlet);
          var fname = portlet.fname;
          var ret = layoutService.addToHome(portlet);
          console.log("market: fname", fname);

Function addToHome has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        vm.addToHome = function(portlet) {
          console.log("addToHome: pportlet", portlet);
          var ret = layoutService.addToHome(portlet);
          console.log("addToHome: ret", ret);
          ret.success(function(request, text) {

Function persistAndUse has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

              var persistAndUse = function(result) {
                $log.log('persistAndUse: got data from old layout backend: ' +
                  result.data.layout);
                var formattedOldLayout = formatLayoutForCache(result.data);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

define(['require'], function(require) {
  return {
    staticMax: {
      templateUrl: require.toUrl('./partials/static-content-max.html'),
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

define(['require'], function(require) {
    return {
        main: {
            templateUrl: require.toUrl('./partials/marketplace.html'),
        },

• Read up
  Read up

Function addToHome has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        vm.addToHome = function(portlet) {
          var ret = layoutService.addToHome(portlet);
          ret.success(function(request, text) {
            angular.element('.fname-' + portlet.fname)
              .html('<span style="color : green;">' +

Function moveWithKeyboard has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      $scope.moveWithKeyboard = function(widget, event) {
        var result = $filter('filter')($scope.$parent.layout, widget);
        var currentIndex = $scope.$parent.layout.indexOf(result[0]);
        var previousIndex = currentIndex - 1;
        var nextIndex = currentIndex + 1;

Function getPortlets has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        var getPortlets = function() {
            return checkMarketplaceCache().then(function(data) {
                var successFn;
                var errorFn;
                var defer;

Function moveWithKeyboard has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      $scope.moveWithKeyboard = function(widget, event) {
        // Get index independent of ng-repeat to avoid filter bugs
        var currentIndex =
          findLayoutIndex($scope.layout, 'nodeId', widget.nodeId);
        var previousIndex = currentIndex - 1;

Identical blocks of code found in 2 locations. Consider refactoring.

Open

              if ($sessionStorage.marketplace != null) {
                // Filter for fname match in marketplace
                var marketplaceEntries = $filter('filter')(
                  $sessionStorage.marketplace, fname
                );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if ($sessionStorage.marketplace != null) {
                // Filter for fname match in marketplace
                var marketplaceEntries = $filter('filter')(
                  $sessionStorage.marketplace, fname
                );

• Read up
  Read up

Function init has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      var init = function() {
        // init variables
        $scope.portlets = [];
        marketplaceService.getPortlets().then(function(data) {
          $scope.portlets = data.portlets;

Function filterAppsBySearchTerm has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      var filterAppsBySearchTerm = function(apps) {
        // Filter by title matches first
        var appsWithMatchingTitle =
          marketplaceService.filterPortletsBySearchTerm(
            apps,

Function getExclusiveMarkup has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        var getExclusiveMarkup = function(portlet) {
          return $http.get(SERVICE_LOC.context +
              '/p/' + portlet.fname + '/exclusive/render.uP', {cache: true})
              .then(function(result) {
                  var data = result.data;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $scope.onSelect = function(portlet) {
          $location.path('apps/details/'+ portlet.fname);
          $scope.initialFilter = '';
          $scope.showSearch = false;
          $scope.showSearchFocus = false;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          if ($scope.initialFilter != '') {
            $location.path('apps/search/'+ $scope.initialFilter);
            $scope.initialFilter = '';
            $scope.showSearch = false;
            $scope.showSearchFocus = false;

• Read up
  Read up

Function invokeCallback has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

        function invokeCallback(expression, event, dropEffect, itemType, index, item) {