ubenzer/rho-on-steroids

View on GitHub

Showing 12 of 12 total issues

Function enhance has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

function enhance(options) {
  debug("Extending rho...");

  // Copy original prototype to be sure that the original is not changed
  var InlineCompiler = function(opts) { rho.InlineCompiler.call(this, opts); };
Severity: Minor
Found in lib/index.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function enhance has 189 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function enhance(options) {
  debug("Extending rho...");

  // Copy original prototype to be sure that the original is not changed
  var InlineCompiler = function(opts) { rho.InlineCompiler.call(this, opts); };
Severity: Major
Found in lib/index.js - About 7 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        if (walk.at("{")) {
          walk.skip(1); // [
          var endType = walk.indexOf("}");
          if (endType === null) {
            pushClosingBracketAfterEmitting = true;
    Severity: Major
    Found in lib/index.js and 2 other locations - About 3 hrs to fix
    lib/index.js on lines 130..139
    lib/index.js on lines 203..212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        if (walk.at("[")) {
          walk.skip(1); // [
          var endType = walk.indexOf("]");
          if (endType === null) {
            pushClosingBracketAfterEmitting = true;
    Severity: Major
    Found in lib/index.js and 2 other locations - About 3 hrs to fix
    lib/index.js on lines 56..65
    lib/index.js on lines 203..212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        if (walk.at("{")) {
          walk.skip(1); // [
          var endFlags = walk.indexOf("}");
          if (endFlags === null) {
            pushClosingBracketAfterEmitting = true;
    Severity: Major
    Found in lib/index.js and 2 other locations - About 3 hrs to fix
    lib/index.js on lines 56..65
    lib/index.js on lines 130..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function tryLink has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      InlineCompiler.prototype.tryLink = function(walk) {
        var self = this;
    
        if (!walk.at("[")) { return false; }
        // Try to find the ]
    Severity: Major
    Found in lib/index.js - About 2 hrs to fix

      Function tryImg has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        InlineCompiler.prototype.tryImg = function(walk) {
          var self = this;
          if (!walk.at("![")) { return false; }
        // Try to find the ]
          walk.skip(2);
      Severity: Minor
      Found in lib/index.js - About 1 hr to fix

        Function tryHeadlessLink has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          InlineCompiler.prototype.tryHeadlessLink = function(walk) {
            if (!walk.at("[[")) { return false; }
            walk.skip(2);
            var linkEnd = walk.indexOf("]]");
            // ]] not found, emitting
        Severity: Minor
        Found in lib/index.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var escapedTypesArr = _.map(types, function(type) { return s(type).trim().escapeHTML().s; });
          Severity: Minor
          Found in lib/index.js and 1 other location - About 35 mins to fix
          lib/index.js on lines 102..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              var escapedFlagsArr = _.map(flags, function(flag) { return s(flag).trim().escapeHTML().s; });
          Severity: Minor
          Found in lib/index.js and 1 other location - About 35 mins to fix
          lib/index.js on lines 81..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

              return true;
          Severity: Major
          Found in lib/index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return true;
            Severity: Major
            Found in lib/index.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language