Sign upLogin

ucberkeley/moocchat

View on GitHub
Star

Showing 132 of 132 total issues

Method evaluateQualificationRequests has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

  private void evaluateQualificationRequests(String qualid, String answerFile,
      boolean preview) {
    
    if (preview) {
        log.info("Preview flag is set. Qualification requests will not be approved or rejected.");
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
 * Copyright 2012 Amazon Technologies, Inc.
 * 
 * Licensed under the Amazon Software License (the "License");
 * you may not use this file except in compliance with the License.
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/UnblockWorker.java and 1 other location - About 4 hrs to fix
turk/src/com/amazonaws/mturk/cmd/BlockWorker.java on lines 1..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 248.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

/*
 * Copyright 2012 Amazon Technologies, Inc.
 * 
 * Licensed under the Amazon Software License (the "License");
 * you may not use this file except in compliance with the License.
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/BlockWorker.java and 1 other location - About 4 hrs to fix
turk/src/com/amazonaws/mturk/cmd/UnblockWorker.java on lines 1..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 248.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method evaluateQualificationRequests has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private void evaluateQualificationRequests(String qualid, String answerFile,
      boolean preview) {
    
    if (preview) {
        log.info("Preview flag is set. Qualification requests will not be approved or rejected.");
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 3 hrs to fix

    Method loadHITs has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {

    HITDataInput hi = new HITDataCSVReader(input);
    HITProperties hc = new HITProperties(props);
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findMostFrequent has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String findMostFrequent(List<String> answers, int[] numMostFreqVotes, int numAssignments) throws UnresolvedAnswerException {
        if(answers == null || answers.size() == 0){
            throw new UnresolvedAnswerException("No answers submitted", ErrorReason.InProgress);
        }
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/summary/SummaryUtils.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createQualificationType has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public boolean createQualificationType(String qualFile, String answerFile,
      String propertiesFile, boolean noRetry) {
    String test = null;
    String answerKey = null;
    Properties props = new Properties();
    Severity: Major
    Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 3 hrs to fix

      Method loadHITs has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {

    HITDataInput hi = new HITDataCSVReader(input);
    HITProperties hc = new HITProperties(props);
      Severity: Major
      Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 2 hrs to fix

        Function showWelcomeMessage has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

          showWelcomeMessage: function(){
    if (this.group.length == 1) {
      this.showMessage("No one is currently available to chat with you. You may use this chatroom to reflect on the question. Click the end button above when done.", "system");
    } else if (this.group.length == 2) {
      var you_learner = '';
        Severity: Minor
        Found in app/assets/javascripts/web_socket.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getContentInContainer(matchClass) {
    var elems = document.getElementsByTagName('*'), i;
    for (i in elems) {
        if((' ' + elems[i].className + ' ').indexOf(' ' + matchClass + ' ')
                > -1) {
        Severity: Major
        Found in public/util.js and 1 other location - About 2 hrs to fix
        public/edxbootstrap.js on lines 28..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getContentInContainer(matchClass) {
    var elems = document.getElementsByTagName('*'), i;
    for (i in elems) {
        if((' ' + elems[i].className + ' ').indexOf(' ' + matchClass + ' ')
                > -1) {
        Severity: Major
        Found in public/edxbootstrap.js and 1 other location - About 2 hrs to fix
        public/util.js on lines 19..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for (int i = 0; qualReqs != null && i < qualReqs.length; i++) {
      try {
        if (comments != null)
          comment = comments[i];
        Severity: Major
        Found in turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java and 1 other location - About 2 hrs to fix
        turk/src/com/amazonaws/mturk/cmd/GrantQualificationRequests.java on lines 141..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for (int i = 0; qualReqs != null && i < qualReqs.length; i++) {
      try {
        if (values != null)
          value = values[i];
        Severity: Major
        Found in turk/src/com/amazonaws/mturk/cmd/GrantQualificationRequests.java and 1 other location - About 2 hrs to fix
        turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java on lines 116..130

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method updateHITs has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public HIT[] updateHITs(String successFile, String props) throws Exception {

    HITProperties hc = new HITProperties(props);

    // Output initializing message
        Severity: Major
        Found in turk/src/com/amazonaws/mturk/cmd/UpdateHITs.java - About 2 hrs to fix

          Method processAnswers has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

            private void processAnswers(Map<String, String> values) {
    String answers = values.get(ORIG_ANSWER_FIELD);

    if (answers == null || HITResults.NO_ANSWER.equals(answers)) {
      return ;  // return if no answers
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/util/HITResultProcessor.java - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateQualificationType has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public void updateQualificationType( String qualTypeId, String statusString,
      String questionFile, String answerFile, 
      String propertiesFile ) throws Exception
  {
    String test = null;
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 2 hrs to fix

            Method approveAssignmentsInFile has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              public void approveAssignmentsInFile(String fileName) throws IOException {
    if (fileName == null) {
      throw new IllegalArgumentException("fileName must not be null");
    }
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/ApproveWork.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method updateStatistics has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              private void updateStatistics(HITResults r) {
    totalAssignments += r.getHIT().getMaxAssignments();
    
    if (r.getHIT().getCreationTime().before(firstHitCreateTime)) {
      firstHitCreateTime=r.getHIT().getCreationTime();
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/GetResults.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createQualificationType has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              public boolean createQualificationType(String qualFile, String answerFile,
      String propertiesFile, boolean noRetry) {
    String test = null;
    String answerKey = null;
    Properties props = new Properties();
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method reviewAssignments has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              public void reviewAssignments(String fileName) throws IOException {
    if (fileName == null) {
      throw new IllegalArgumentException("File name is null.");
    }
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/ReviewResults.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language